Subject: Re: Plans for 2.8
To: psycopg@lists.postgresql.org
References: 
 <CA+mi_8auWr+u4DwLGnu3JOu=jhMAV_8OPnMtMuXOr+0iMN5LgA@mail.gmail.com>
From: Federico Di Gregorio <fog@dndg.it>
Organization: DNDG srl
Message-ID: <3e4f0570-863a-6dfd-aaa9-d0b406af9d76@dndg.it>
Date: Thu, 4 Oct 2018 15:27:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CA+mi_8auWr+u4DwLGnu3JOu=jhMAV_8OPnMtMuXOr+0iMN5LgA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/04/2018 02:38 PM, Daniele Varrazzo wrote:
> A tiny improvement to SQL generation is already ready^W merged in
> #732: it will be possible to use `Identifier("schema", "name")` which
> would be rendered in dotted notation in the query. Currently
> `Identifier()` takes a single param so this extension is backward
> compatible and there is no need to introduce a new `Composable` type
> to represent dotted sequences of identifiers.

I understand that from a compatibility point of view everything works 
with the "schema", "name" order of arguments (you just switch on the 
number of arguments) but usually such approach causes infinite headaches 
when you remove or add the namespace from the call.

`Identifier(name, schema=None)` is better, IMHO because makes explicit 
that the mandatory and first argument is always the identifier itself, 
while the schema is optional.

federico

-- 
Federico Di Gregorio                         federico.digregorio@dndg.it
DNDG srl                                                  http://dndg.it
      One key. One input. One enter. All right. -- An american consultant
            (then the system crashed and took down the *entire* network)