Feedback-ID: i76984098:Fastmail
Message-ID: <4a1b12fc-24b7-4c7e-b1f2-6ec9c5f341c2@aklaver.com>
Date: Sat, 7 Sep 2024 14:09:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: psycopg2: proper positioning of .commit() within try: except:
 blocks
To: Karsten Hilbert <Karsten.Hilbert@gmx.net>
Cc: psycopg@lists.postgresql.org, python-list@python.org
References: <Ztx1sZMGTnA3eLP1@hermes.hilbert.loc>
 <7cb50df2-9c76-477f-91c9-e149c7637104@aklaver.com>
 <ZtytJMhyvtExPxfF@hermes.hilbert.loc>
 <5ee80b84-f04b-454d-ab39-45572e0751a1@aklaver.com>
 <Zty7ZCMwKQl4C4Id@hermes.hilbert.loc>
Content-Language: en-US
From: Adrian Klaver <adrian.klaver@aklaver.com>
In-Reply-To: <Zty7ZCMwKQl4C4Id@hermes.hilbert.loc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4a1b12fc-24b7-4c7e-b1f2-6ec9c5f341c2%40aklaver.com>
Precedence: bulk

On 9/7/24 13:45, Karsten Hilbert wrote:
> Am Sat, Sep 07, 2024 at 01:03:34PM -0700 schrieb Adrian Klaver:
> 
>> In the case you show you are doing commit() before the close() so any errors in the
>> transactions will show up then. My first thought would be to wrap the commit() in a
>> try/except and deal with error there.
> 
> Right, and this was suggested elsewhere ;)
> 
> And, yeah, the actual code is much more involved :-D
> 

I see that.

The question is does the full code you show fail?

The code sample you show in your original post is doing something very 
different then what you show in your latest post. At this point I do not 
understand the exact problem we are dealing with.


> 
> 
> Best,
> Karsten
> --
> GPG  40BE 5B0E C98E 1713 AFA6  5BC0 3BEA AC80 7D4F C89B

-- 
Adrian Klaver
adrian.klaver@aklaver.com