Subject: Re: Feature branches merged to master for 2.8 release
To: psycopg@lists.postgresql.org
References: 
 <CA+mi_8aVzn-4Ujuqg5aMduHjL1XQ3Y7sUU86s3p6shMefaPoSQ@mail.gmail.com>
 <1878453370.14916776.1539604797985@mail.yahoo.com>
 <CA+mi_8bSZw7CAFPOKyanYVu2_AbP-+gcUd8N7oD-oisgth6o6A@mail.gmail.com>
 <62b46b76-ce7f-6b89-b5ad-d0f2c2533432@dndg.it>
 <1820701010.20861820.1540152265403@mail.yahoo.com>
 <1390677301.27162879.1540762541620@mail.yahoo.com>
 <CA+mi_8bV4sq2HgAvMEx3ea6semu7g9pmwaW3gej4-peJHzO9Dg@mail.gmail.com>
 <20181029105422.GD2262@hermes.hilbert.loc>
From: Federico Di Gregorio <fog@dndg.it>
Organization: DNDG srl
Message-ID: <67b7bfb4-0a44-b914-c61f-464e1385da13@dndg.it>
Date: Mon, 29 Oct 2018 12:48:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181029105422.GD2262@hermes.hilbert.loc>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: it-IT
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/29/2018 11:54 AM, Karsten Hilbert wrote:
> On Mon, Oct 29, 2018 at 10:49:14AM +0000, Daniele Varrazzo wrote:
> 
>> There are always differences, in interfaces and in behaviour, between
>> dbapi drivers. A private method, returning two objects which are
>> different because they are very simply two database drivers, are not
>> the place where to start trying to unify interfaces. What you do, if
>> you want to deal with both drivers, is to write a wrapper unifying the
>> interfaces. I would be ok to adapt other drivers choices, if I agreed
>> with them, but I can't agree with an underscore method being
>> documented as part of the API: that's internal stuff and totally not
>> idiomatic Python.
>>
>> My vote goes to have this method name without underscore, but I'll
>> leave the final decision to Federico.
> Apart from a wrapper class one can always monkey-patch
> 
> 	my_dbapi_instance._get_native_connection = my_dbapi_instance.get_native_connection
> 
> at runtime.

Right.

federico

-- 
Federico Di Gregorio                         federico.digregorio@dndg.it
DNDG srl                                                  http://dndg.it
  But not all bugs are an interesting challenge. Some are just a total
   waste of my time, which usually is much more valuable than the time of
   the submitter.                                                   -- Md