MIME-Version: 1.0
References: 
 <CA+mi_8aVzn-4Ujuqg5aMduHjL1XQ3Y7sUU86s3p6shMefaPoSQ@mail.gmail.com>
 <1878453370.14916776.1539604797985@mail.yahoo.com>
 <CA+mi_8bSZw7CAFPOKyanYVu2_AbP-+gcUd8N7oD-oisgth6o6A@mail.gmail.com>
 <62b46b76-ce7f-6b89-b5ad-d0f2c2533432@dndg.it>
 <1820701010.20861820.1540152265403@mail.yahoo.com>
 <1390677301.27162879.1540762541620@mail.yahoo.com>
 <CA+mi_8bV4sq2HgAvMEx3ea6semu7g9pmwaW3gej4-peJHzO9Dg@mail.gmail.com>
 <d8ae3ea6-1fc2-36aa-e32f-62c0f6109254@dndg.it>
In-Reply-To: <d8ae3ea6-1fc2-36aa-e32f-62c0f6109254@dndg.it>
From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Mon, 29 Oct 2018 12:07:44 +0000
Message-ID: 
 <CA+mi_8b9rM8+wo=f1Z3wTfH+D0J047mFYm=G5ZXJx8VOdXhoqg@mail.gmail.com>
Subject: Re: Feature branches merged to master for 2.8 release
To: Federico Di Gregorio <fog@dndg.it>
Cc: psycopg@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 29, 2018 at 11:47 AM Federico Di Gregorio <fog@dndg.it> wrote:

> I agree with
> Daniele here but the fact that the *content* of the capsule, i.e., the
> PGconn* can change depending of the libpq version you're loading is
> pretty scary. I'd like to warn the client code (Python warnings to be
> suppressed? mm..) but just prepending an underscore to the method name
> doesn't mean much. If we add `get_native_connection()` then it becomes
> an official and supported psycopg extensions and doesn't make sense to
> mark it as private API.

The PGconn is an opaque structure: its correct usage is through the
libpq functions. See also the note in
<https://www.postgresql.org/docs/current/static/libpq-status.html>:
"libpq application programmers should be careful to maintain the
PGconn abstraction. Use the accessor functions described below to get
at the contents of PGconn. Reference to internal PGconn fields using
libpq-int.h is not recommended because they are subject to change in
the future." If the structure changes and someone gets bitten by it
it's not really related to how much private the method is.


-- Daniele