MIME-Version: 1.0
References: 
 <CA+mi_8aVzn-4Ujuqg5aMduHjL1XQ3Y7sUU86s3p6shMefaPoSQ@mail.gmail.com>
 <1878453370.14916776.1539604797985@mail.yahoo.com>
 <CA+mi_8bSZw7CAFPOKyanYVu2_AbP-+gcUd8N7oD-oisgth6o6A@mail.gmail.com>
 <62b46b76-ce7f-6b89-b5ad-d0f2c2533432@dndg.it>
 <1820701010.20861820.1540152265403@mail.yahoo.com>
 <1390677301.27162879.1540762541620@mail.yahoo.com>
In-Reply-To: <1390677301.27162879.1540762541620@mail.yahoo.com>
From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Mon, 29 Oct 2018 10:49:14 +0000
Message-ID: 
 <CA+mi_8bV4sq2HgAvMEx3ea6semu7g9pmwaW3gej4-peJHzO9Dg@mail.gmail.com>
Subject: Re: Feature branches merged to master for 2.8 release
To: Christian Ferrari <camauz@yahoo.com>
Cc: psycopg@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 28, 2018 at 9:35 PM Christian Ferrari <camauz@yahoo.com> wrote:
>
> Dear All,
> today I have released LIXA 1.7.1 with Python/Psycopg2 support.
> To avoid two different methods (get_native_connection() for PostgreSQL an=
d _get_native_connection() for MySQL/MariaDB) I have created a fork of Psyc=
opg2 https://github.com/tiian/psycopg2/tree/get-native-connection with the =
code provided by Federico and method "get_native_connection" renamed.
> For the sake of convenience I have created a pull request: https://github=
.com/psycopg/psycopg2/pull/798 feel free to integrate it or to go on with t=
he process you figured out in the past.
> Kind Regards
> Ch.F.

I don't know what Federico had decided but I'd very much prefer the
name without underscore. Methods with underscore don't belong to an
object interface.

There are always differences, in interfaces and in behaviour, between
dbapi drivers. A private method, returning two objects which are
different because they are very simply two database drivers, are not
the place where to start trying to unify interfaces. What you do, if
you want to deal with both drivers, is to write a wrapper unifying the
interfaces. I would be ok to adapt other drivers choices, if I agreed
with them, but I can't agree with an underscore method being
documented as part of the API: that's internal stuff and totally not
idiomatic Python.

My vote goes to have this method name without underscore, but I'll
leave the final decision to Federico.

-- Daniele