MIME-Version: 1.0
References: 
 <CA+mi_8aZQXzB8Kr4V0nps3aMQ74N72uWC=pZF0P1H7AW4GLasA@mail.gmail.com>
 <YAWJcSDmciAKptEK@hermes.hilbert.loc>
 <CA+mi_8a-0Wx62eziOBwp-=ryBynsqrgx4AcBGW5+pSr3vZXjHg@mail.gmail.com>
In-Reply-To: 
 <CA+mi_8a-0Wx62eziOBwp-=ryBynsqrgx4AcBGW5+pSr3vZXjHg@mail.gmail.com>
From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 18 Jan 2021 15:05:10 +0100
Message-ID: 
 <CABUevExMQQB3=xShPie+XR04kctiR8-P_BEUz1BmCyDLhU_yhg@mail.gmail.com>
Subject: Re: Designing a better connection pool for psycopg3
To: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Cc: psycopg@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 18, 2021 at 2:50 PM Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:
>
> On Mon, 18 Jan 2021 at 14:13, Karsten Hilbert <Karsten.Hilbert@gmx.net> wrote:
>
> > I would strongly advise against making sys.exit() the default
> > for pool.terminate() unless I misunderstand something.
>
> How would you terminate the program if a maintenance thread, not the
> main one, thinks that the program is not in working state?

Why would it be OK for a maintenance thread to terminate the program
at all? And certainly by default?

Wouldn't the reasonable thing to do be to flag the pool as broken, and
then just stop trying. Then whenever the application makes an attempt
to use the pool, it can he thrown an exception saying that this
happened.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/