MIME-Version: 1.0
References: 
 <CAFzonYY=gW5cG9oJNGkF-6vzYvNvg9BB1CCfVkeqYGCKzH=9PQ@mail.gmail.com>
 <CA+mi_8YJRfD5m1khR8ozj6S9D8_JLdLdf6m_DsHAxYO_9B1f0A@mail.gmail.com>
In-Reply-To: 
 <CA+mi_8YJRfD5m1khR8ozj6S9D8_JLdLdf6m_DsHAxYO_9B1f0A@mail.gmail.com>
From: Jason Erickson <jerickso@stickpeople.com>
Date: Tue, 5 Oct 2021 12:10:51 -0600
Message-ID: 
 <CAFpJua0K5hVfg+yUVD8YdJXDYK=PT5xcZnF-6cdsiwCZe3gUew@mail.gmail.com>
Subject: Re: How to build statically on Windows
To: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Cc: Dan Davis <dansmood@gmail.com>, psycopg@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000ca2f1805cd9ef323"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFpJua0K5hVfg%2ByUVD8YdJXDYK%3DPT5xcZnF-6cdsiwCZe3gUew%40mail.gmail.com>
Precedence: bulk

--000000000000ca2f1805cd9ef323
Content-Type: text/plain; charset="UTF-8"

Hi Dan,

Yeah, unfortunately --static-libpq doesn't do what it should anymore.  We
should remove that option.

When building pyscopg2 from source, the binary Windows Postgres packages
does not include the statically linked library (In fairness, I haven't
checked the latest packages, but that is how it has been in the past).  The
library included with the binary packages was the DLL import library and it
was named libpq.lib.  This is an issue, because originally when you built
from source on windows, the file libpq.lib was the static link library,
whereas the DLL import library was named libpqdll.lib.  So we have a name
inconsistency and no way to link statically with the Postgres binary
distribution.

This got even more convoluted a few major versions back with the source of
Postgres, as the Windows perl build scripts quit creating the build file
for the static link library, only building the DLL import library AND
naming it libpq.lib.  With our Appveyor build script, I cheated and
modified the perl script to build the library instead of the DLL at this
line:
      file_replace('Mkvcbuild.pm', "'libpq', 'dll'", "'libpq', 'lib'")

With that said, I am not happy with that solution and always intended to
revisit the setup script portion for windows, but always had more questions
than answers, some of them:
* If static libraries are not part of the Postgres binary distribution (or
even the build from source option by default), do we concern ourselves with
them? Personally I prefer static libraries because I think it has less
support issues, but???
* If people are building psycopg from source, what libraries do we assume
they have installed?  pg_config probably would not be working, so
include/library paths would have to be passed. What about other
dependencies (ie openssl, still use the has_ssl flag?)?  There are slightly
different link libraries between some Postgres, so versions matter, too.
* Do we try to differentiate between the DLL import library and the static
library since the name can be the same between them (size?)?
* Or do we say heck with it and just link against a file named libpq.lib,
letting the builder point to the libpq they want to use?

Maybe an option is to have setup.py on windows call the appveyor script
(with some modifications) and build everything from scratch?  It takes
about 40 minutes to build everything, tho, and does require some storage
space for the source and build files, so not the best solution.

-jason


On Mon, Oct 4, 2021 at 5:13 PM Daniele Varrazzo <daniele.varrazzo@gmail.com>
wrote:

> Hi Dan,
>
> On Tue, 5 Oct 2021 at 01:01, Dan Davis <dansmood@gmail.com> wrote:
> >
> > Can anyone give me a solution to build psycopg2 statically on Windows?
> >
> > I have succeeded in building it, but when I run dumpbin /dependents on
> the generated file (the PYD file), it still depends on libpq.dll even when
> I pass --static-libpq.
>
> I haven't personally used --static-libpq in a long time, and neither
> have I used windows for a while. As far as I know that part of the set
> up might have bitrotten.
>
> If anyone can help Dan it would be appreciated.
>
> Dan, there is a ticket/MR in the tracker of which I've never been able
> to make completely sense: https://github.com/psycopg/psycopg2/pull/758
> Would you like to check if that's the issue that doesn't allow
> building the lib statically and if so can you propose a MR or just
> acknowledge that the proposed one works as expected?
>
> Thank you everyone
>
> -- Daniele
>
>
>

--000000000000ca2f1805cd9ef323
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Dan,</div><div><br></div><div>Yeah, unfortunately =
--static-libpq doesn&#39;t do what it should anymore.=C2=A0 We should remov=
e that option.</div><div><br></div><div>When building pyscopg2 from source,=
 the binary Windows Postgres packages does not include the statically linke=
d library (In fairness, I haven&#39;t checked the latest=C2=A0packages, but=
 that is how it has been in the past).=C2=A0 The library included with the =
binary packages was the DLL import library and it was named libpq.lib.=C2=
=A0 This is an issue, because originally when you built from source on wind=
ows, the file libpq.lib was the static link library, whereas the DLL import=
 library was named libpqdll.lib.=C2=A0 So we have a name inconsistency and=
=C2=A0no way to link statically with the Postgres binary distribution.<br><=
/div><div><div><br></div><div><div>This got even more convoluted a few majo=
r versions back with the source of Postgres, as the Windows perl build scri=
pts quit creating the build file for the static link library, only building=
 the DLL import library AND naming it libpq.lib.=C2=A0 With our Appveyor bu=
ild script, I cheated and modified the perl script to build the library ins=
tead of the DLL at this line:</div><div>=C2=A0 =C2=A0 =C2=A0 f<span class=
=3D"gmail-pl-en">ile_replace</span>(<span class=3D"gmail-pl-s">&#39;Mkvcbui=
ld.pm&#39;</span>, <span class=3D"gmail-pl-s">&quot;&#39;libpq&#39;, &#39;d=
ll&#39;&quot;</span>, <span class=3D"gmail-pl-s">&quot;&#39;libpq&#39;, =
9;lib&#39;&quot;</span>)</div><div><br></div><div>With that said, I am not =
happy with that solution and always intended to revisit the setup script po=
rtion for windows, but always had more questions than answers, some of them=
:</div></div></div><div>* If static libraries are not part of the Postgres=
=C2=A0binary distribution (or even the build from source option by default)=
, do we concern ourselves with them? Personally I prefer static libraries b=
ecause I think it has less support issues, but???<br></div><div>* If people=
 are building psycopg from source, what libraries do we assume they have in=
stalled?=C2=A0 pg_config probably would not be working, so include/library =
paths would have to be passed. What about other dependencies (ie openssl, s=
till use the has_ssl flag?)?=C2=A0 There are slightly different link librar=
ies between some Postgres, so versions matter, too.<br></div><div>* Do we t=
ry to differentiate between the DLL import library and the static library s=
ince the name can be the same between them (size?)?</div><div>* Or do we sa=
y heck with it and just link against a file named libpq.lib, letting the bu=
ilder point to the libpq they want to use?</div><div><br></div><div>Maybe a=
n option is to have setup.py on windows call the appveyor script (with some=
 modifications) and build everything from scratch?=C2=A0 It takes about 40 =
minutes to build everything, tho, and does require some storage space for t=
he source and build files, so not the best solution.</div><div><br></div><d=
iv>-jason</div><div><br></div></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Mon, Oct 4, 2021 at 5:13 PM Daniele Varraz=
zo &lt;<a href=3D"mailto:daniele.varrazzo@gmail.com" target=3D"_blank">dani=
ele.varrazzo@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex">Hi Dan,<br>
<br>
On Tue, 5 Oct 2021 at 01:01, Dan Davis &lt;<a href=3D"mailto:dansmood@gmail=
.com" target=3D"_blank">dansmood@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Can anyone give me a solution to build psycopg2 statically on Windows?=
<br>
&gt;<br>
&gt; I have succeeded in building it, but when I run dumpbin /dependents on=
 the generated file (the PYD file), it still depends on libpq.dll even when=
 I pass --static-libpq.<br>
<br>
I haven&#39;t personally used --static-libpq in a long time, and neither<br=
>
have I used windows for a while. As far as I know that part of the set<br>
up might have bitrotten.<br>
<br>
If anyone can help Dan it would be appreciated.<br>
<br>
Dan, there is a ticket/MR in the tracker of which I&#39;ve never been able<=
br>
to make completely sense: <a href=3D"https://github.com/psycopg/psycopg2/pu=
ll/758" rel=3D"noreferrer" target=3D"_blank">https://github.com/psycopg/psy=
copg2/pull/758</a><br>
Would you like to check if that&#39;s the issue that doesn&#39;t allow<br>
building the lib statically and if so can you propose a MR or just<br>
acknowledge that the proposed one works as expected?<br>
<br>
Thank you everyone<br>
<br>
-- Daniele<br>
<br>
<br>
</blockquote></div>

--000000000000ca2f1805cd9ef323--