MIME-Version: 1.0
References: 
 <CA+mi_8Y+-0Tdb7ka9vnRVZgpa_hMWN1rB-K74+=idAeWFPSaUg@mail.gmail.com>
In-Reply-To: 
 <CA+mi_8Y+-0Tdb7ka9vnRVZgpa_hMWN1rB-K74+=idAeWFPSaUg@mail.gmail.com>
From: Marco De Paoli <depaolim@gmail.com>
Date: Fri, 12 Oct 2018 22:53:04 +0200
Message-ID: 
 <CAPz0FjBmYo+VFUR_=cje5LsaU5qDWkJaQA0bXO=g51i1_uu=zw@mail.gmail.com>
Subject: Re: Adding an informative object to the connection
To: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Cc: psycopg@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000c15e1b05780e46fe"
Precedence: bulk

--000000000000c15e1b05780e46fe
Content-Type: text/plain; charset="UTF-8"

Hi Daniele,

Il giorno ven 12 ott 2018 alle ore 18:46 Daniele Varrazzo <
daniele.varrazzo@gmail.com> ha scritto:

> Hi,
>
> a few days ago we were contributed a merge request for an `.host`
> attribute on the connection. But looking back at the bug
> (https://github.com/psycopg/psycopg2/issues/726) I had already noticed
> there are other interesting informative connection functions in the
> libpq. Some of them are already exposed as methods of the connection
> class (e.g. get_backend_pid(), get_transaction_status() etc), but I
> can see a trickle of requests for others, so I'd rather expose
> most/all of them.
>
> Instead of bloating the connection class with more and more attributes
> and methods, I'm rather adding a connection.info method to retrieve
> pgconn-specific information. The work is happening in this branch:
>
> https://github.com/psycopg/psycopg2/commits/connection-info
>
> I would softly deprecate the currently exposed informative methods:
> not sending them away in a short time but giving a preference to use
> from the 'info' object what belongs to the pgconn/libpq and to leave
> on the connection things regarding the Python layer, and clean up the
> interfaces a little bit.
>
> Any input is welcome. Cheers!
>

+1
good idea, clean and effective

-- Marco

--000000000000c15e1b05780e46fe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Daniele,<br><br><div class=3D"gmail_quote"><div dir=3D"=
ltr">Il giorno ven 12 ott 2018 alle ore 18:46 Daniele Varrazzo &lt;<a href=
=3D"mailto:daniele.varrazzo@gmail.com">daniele.varrazzo@gmail.com</a>&gt; h=
a scritto:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
a few days ago we were contributed a merge request for an `.host`<br>
attribute on the connection. But looking back at the bug<br>
(<a href=3D"https://github.com/psycopg/psycopg2/issues/726" rel=3D"noreferr=
er" target=3D"_blank">https://github.com/psycopg/psycopg2/issues/726</a>) I=
 had already noticed<br>
there are other interesting informative connection functions in the<br>
libpq. Some of them are already exposed as methods of the connection<br>
class (e.g. get_backend_pid(), get_transaction_status() etc), but I<br>
can see a trickle of requests for others, so I&#39;d rather expose<br>
most/all of them.<br>
<br>
Instead of bloating the connection class with more and more attributes<br>
and methods, I&#39;m rather adding a <a href=3D"http://connection.info" rel=
=3D"noreferrer" target=3D"_blank">connection.info</a> method to retrieve<br=
>
pgconn-specific information. The work is happening in this branch:<br>
<br>
<a href=3D"https://github.com/psycopg/psycopg2/commits/connection-info" rel=
=3D"noreferrer" target=3D"_blank">https://github.com/psycopg/psycopg2/commi=
ts/connection-info</a><br>
<br>
I would softly deprecate the currently exposed informative methods:<br>
not sending them away in a short time but giving a preference to use<br>
from the &#39;info&#39; object what belongs to the pgconn/libpq and to leav=
e<br>
on the connection things regarding the Python layer, and clean up the<br>
interfaces a little bit.<br>
<br>
Any input is welcome. Cheers!<br></blockquote><div><br></div><div>+1<br></d=
iv><div>good idea, clean and effective</div><div><br></div><div>-- Marco</d=
iv></div></div>

--000000000000c15e1b05780e46fe--