Date: Mon, 18 Jan 2021 15:44:15 +0100
From: Karsten Hilbert <Karsten.Hilbert@gmx.net>
To: psycopg@lists.postgresql.org, psycopg@postgresql.org
Subject: Re: Designing a better connection pool for psycopg3
Message-ID: <YAWevy8n7/CA0o7I@hermes.hilbert.loc>
Mail-Followup-To: psycopg@lists.postgresql.org, psycopg@postgresql.org
References: 
 <CA+mi_8aZQXzB8Kr4V0nps3aMQ74N72uWC=pZF0P1H7AW4GLasA@mail.gmail.com>
 <YAWJcSDmciAKptEK@hermes.hilbert.loc>
 <CA+mi_8a-0Wx62eziOBwp-=ryBynsqrgx4AcBGW5+pSr3vZXjHg@mail.gmail.com>
 <CABUevExMQQB3=xShPie+XR04kctiR8-P_BEUz1BmCyDLhU_yhg@mail.gmail.com>
 <CA+mi_8a83=Qy-Ym+_X4tLPcD1YHVVVYF2Ki5jeHU4eDz_etG5w@mail.gmail.com>
 <CABUevEy6iYxAgH6qFJN5OqiPFkv1O1JU90jbHna2xDXqFDLFHg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CABUevEy6iYxAgH6qFJN5OqiPFkv1O1JU90jbHna2xDXqFDLFHg@mail.gmail.com>
Ma_X_il-Followup-to: d
Re_X_turn-receipt-to: Karsten.Hilbert@gmx.net
Di_X_sposition-Notification-To: Karsten.Hilbert@gmx.net
X-Confi_X_rm-Reading-To: Karsten.Hilbert@gmx.net
X-Pri_X_ority: 2 (High)
Sender: <karsten.hilbert@gmx.net>
X-Provags-ID: V03:K1:o+l+eaSZm1ROXLGU8H/fN0elQgHc+qyHDqmMAwWXxwM6RgPzlgp
 3xivAdHreOBFetXGdP4K6ZRmJrIoT42Uc2rbZ/mqtHwq7cS0c1GpmtoMGXqTJQrLfeT/Ayl
 bdEqCDJlPv40HpXN1ZUMWAvcs/lvPS7Qo6HDLCHCr1c0NemabXQ2fW6dRVZDkzM2jewFl/9
 yDG95MXnJ+tuu+pZJoFuw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:cqPG2O3X6cs=:4pD5Fhmi60eDp3pU1TeaC/
 4H6q7fEY6n2i3LMBrbN+EEHkLRALssWscoaRR1odKj+uyYEga7pQpAKtGuCAhPFCpP5xpidR6
 3Pd1shkAb7hA/MIhJGTpdzuJFD/WukFrQ/n4ERs1TI0y8pvZ0RzS4DyHk0SvLU+tadec381OU
 KczjUoWpC4lbucZHNiviI21UZdklpEExVEzC0h4QFvUpEY1MtoNF+MBv+NHC6OYL2pMl7SH2K
 +RJx9WN6Ky50KQcYg98uZaYn2ADD0e0rvErSETFSWTOwwuvhBYJW/wmwsyXrZQl8T6wkgP/kS
 +mcte9MhjRuSLa2xZKpkPyGl8AVD2ha+mQRPUga5xtyjPhcOxYGj0HUFIoM7FA94ZVYsI9sDu
 l78CeO+5MVRY6oj9POeDbVZlfUqsPGCO5FbXEhE+LGuPuMNSF51LYEpx6L60C3AOvYmrjV6oP
 YAJgfH7KLG5ncHgRRQLOMGNRAk+tDwuO4dTXT7C32lQltb0df4lwrWYlggW1ljAdbLjskrlXA
 MWFfrrFDvxMQ2EGWFxxtS5XVn9epLZZLg+9vz123e+hnBE+zC0uqrE3xfdAv+du4CySL4+UcG
 /yXXI2r7zKcAjxmRpkJEuqwfDTPr1qvYqVwL7ZN9iyHIkdP5Cx1wFzic4QESO64djZs+YHhEx
 Nb6NQjEZaKlghxt5mj3uBU98p0dvCgQeJ8Wr+kAYDQnjU5IvT5Io++jJQOVqf8P58AN1Ck5kn
 GSffCUwVDGhq3sfixrnA5ydEFe4zp4pQeaOPEfbAaW3a0ZxewhliunVpD6BuqP6651sPNU2CY
 RZAG9tc6lx5l/EVVrjBZOxVguSVowDUQscvuGtnAfT/gigVLzYloCTe2cAo/TZugHvBrqmtu6
 aw3oTf9IIBEunG/tr65g==
Content-Transfer-Encoding: quoted-printable
List-Id: <psycopg.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:psycopg@lists.postgresql.org>
List-Owner: <mailto:psycopg-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/psycopg>
Precedence: bulk

Am Mon, Jan 18, 2021 at 03:39:20PM +0100 schrieb Magnus Hagander:

> > Anyway I appreciate that the default of terminating a program is
> > probably too aggressive. So I would remove the `terminate()` function
> > and base implementation and leave a `connection_failed()` handler,
> > with a default no-op implementation, which people preferring their
> > program to terminate can subclass (with `sys.exit(1)` or whatever
> > termination strategy they find useful).
>
> That would definitely work. A plugin-point for this would be very useful=
.
>
> And if you want to avoid the "timeout based error" in the client,
> adding a flag to the pool saying "this pool is currently unhealthy" in
> this case would work, and then whenever someone tries to get a
> connection out of this pool it can throw an exception immediately
> instead of waiting for a timeout to happen.

+1 :-)

Karsten
=2D-
GPG  40BE 5B0E C98E 1713 AFA6  5BC0 3BEA AC80 7D4F C89B