Subject: Re: Integration of Psycopg with XTA
To: psycopg@lists.postgresql.org
References: <fb26f9db-d7ea-5863-a000-abbbef50ec12@dndg.it>
 <f6872d16-9da4-576f-bffe-1ee3c1fd81da@dndg.it>
 <1005537726.6324310.1538685211791@mail.yahoo.com>
 <602182297.6960405.1538755378178@mail.yahoo.com>
 <618fbba4-0f31-2e44-8517-a158cccbef0d@dndg.it>
 <1164838604.11237894.1539205855738@mail.yahoo.com>
From: Federico Di Gregorio <fog@dndg.it>
Organization: DNDG srl
Message-ID: <b0b9d7ac-d2fb-45eb-88b1-235841ef1be1@dndg.it>
Date: Wed, 10 Oct 2018 23:19:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1164838604.11237894.1539205855738@mail.yahoo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: it-IT
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/10/2018 11:10 PM, Christian Ferrari wrote:
> By the way, PyMySQL/mysqlclient-python project 
> <https://github.com/PyMySQL/mysqlclient-python> asked me to rename the 
> method from "get_native_conn()" to "_get_native_conn()".
> 
> I'm not a "naming addicted person", but from the developer point of 
> view, using two different methods would be for sure not appreciated...
> 
> xar1 = PostgresqlXaResource(rm1.get_native_connection(), "PostgreSQL", 
> "dbname=testdb")
> xar2 = MysqlXaResource(rm2._get_native_connection(), "MySQL", 
> "localhost,0,lixa,,lixa")
> 
> If you don't mind, I kindly ask you to wait a couple of days: I hope to 
> close the pull request 
> https://github.com/PyMySQL/mysqlclient-python/pull/269 shortly...

I think that _if_ this should go cross-database a method without the 
underscore is better. The underscore usually means private and that's 
good as long as it is just that. An informal "standard" method name 
should not have the "_" in it.

federico

-- 
Federico Di Gregorio                         federico.digregorio@dndg.it
DNDG srl                                                  http://dndg.it
   Gli esseri umani, a volte, sono destinati, per il solo fatto di
    esistere, a fare del male a qualcuno.              -- Haruki Murakami