Subject: Re: Feature branches merged to master for 2.8 release
To: psycopg@lists.postgresql.org
References: 
 <CA+mi_8aVzn-4Ujuqg5aMduHjL1XQ3Y7sUU86s3p6shMefaPoSQ@mail.gmail.com>
 <20181015121154.GC2008@hermes.hilbert.loc>
 <CA+mi_8bRgi5rFZbnVAiDLK_B-ZLNa-ze9uK6y3WONHu_zq1u_Q@mail.gmail.com>
From: Federico Di Gregorio <fog@dndg.it>
Organization: DNDG srl
Message-ID: <ce1a89ba-2313-711c-93da-f7f0a5915ce0@dndg.it>
Date: Mon, 15 Oct 2018 19:36:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CA+mi_8bRgi5rFZbnVAiDLK_B-ZLNa-ze9uK6y3WONHu_zq1u_Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: it-IT
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/15/2018 07:23 PM, Daniele Varrazzo wrote:
> On Mon, Oct 15, 2018 at 1:12 PM Karsten Hilbert<Karsten.Hilbert@gmx.net>  wrote:
>> On Mon, Oct 15, 2018 at 12:48:04PM +0100, Daniele Varrazzo wrote:
>>
>>> - the new 'errors' module. About it I have a doubt: we convert
>>> postgres error messages [2] from lower_case to CamelCase because the
>>> latter is the convention for Python class, but maybe leaving as they
>>> are makes more sense? Easier to google for them or grep for them in
>>> the postgres sources maybe?
>> Since there is no Right or Wrong here, the "best" option
>> might be to offer both:
>>
>> Raise whatever is Right for Python (that is, CamelCase)
>>
>>          raise PostgresSpecificError
>>
>> but support catching lower case, too:
>>
>>          class postgres_specific_error(PostgresSpecificError):
>>                  pass
>>
>>          try:
>>                  something()
>>          except postgres_specific_error:
>>                  print('lower case')
>>
>> For the lower case one I would exactly copy what's used by
>> PostgreSQL itself.
>>
>> Make sense ?
> I think it's responsible to make a decision. Having two names to refer
> to a thing is confusing. One of the two would be the "blessed" one -
> the one appearing in the tracebacks. And if a traceback says that
> 'unique_violation' was raised, it would be weird to solve it by
> writing a handler for 'UniqueViolation'.
> 
> Plus, that module defines already 232 classes (as of Postgres 11): I
> wouldn't like doubling their number. I'm pondering whether to write it
> as a C module instead of Python but I'm not overly fussed by that.
> 
> So I'd say lower_case or CamelCase, not both.

Python exceptions are CamelCase in 99% of the cases (pun intended).
Lets not have every single Python programmer out there hate us because 
we decided to import a database backend convention into a programming 
laguage.

federico

-- 
Federico Di Gregorio                         federico.digregorio@dndg.it
DNDG srl                                                  http://dndg.it
               Una nazionale senza neanche una nazione. -- macchinavapore