postgres.git / summary / log / commit / refs

commit    629520be5f9da9d0192c7f6c8796bfddb4746760
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Tue Jul 09 12:03:56 2024 +0000
First released in: 18.0

    Fix comment in libpqrcv_check_conninfo().
    
    Previously, the comment incorrectly stated that libpqrcv_check_conninfo()
    returns true or false based on the connection string check.
    However, this function actually has a void return type and
    raises an error if the check fails.
    
    Author: Rintaro Ikeda
    Reviewed-by: Jelte Fennema-Nio, Fujii Masao
    Discussion: https://postgr.es/m/6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com


 src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 02f12f29219..6c42c209d29 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -305,12 +305,12 @@ bad_connection:
 }
 
 /*
- * Validate connection info string, and determine whether it might cause
- * local filesystem access to be attempted.
+ * Validate connection info string.
  *
  * If the connection string can't be parsed, this function will raise
- * an error and will not return. If it can, it will return true if this
- * connection string specifies a password and false otherwise.
+ * an error. If must_use_password is true, the function raises an error
+ * if no password is provided in the connection string. In any other case
+ * it successfully completes.
  */
 static void
 libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)


[parent: ca481d3c9ab7]