postgres.git / summary / log / commit / refs

commit    a1333ec048fb95ff47a5fc10a9cfde69fdbd2b01
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Jul 01 03:20:57 2024 +0000
First released in: 18.0, 17.0

    Further weaken new pg_createsubscriber test on Windows.
    
    Also omit backslashes (\) in the generated database names on Windows.
    As before, perhaps we can revert this after updating affected
    buildfarm animals.
    
    Discussion: https://postgr.es/m/2509767.1719773880@sss.pgh.pa.us


 src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
index 8e8d3f0a02a..1241bf6c6a7 100644
--- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
+++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
@@ -30,8 +30,9 @@ sub generate_db
 
 	$dbname .= $suffix;
 
-	# Old IPC::Run mis-quotes command line arguments containing '"' on Windows
-	$dbname =~ tr/\"//d if ($windows_os);
+	# On Windows, older IPC::Run versions can mis-quote command line arguments
+	# containing double quote or backslash
+	$dbname =~ tr/\"\\//d if ($windows_os);
 
 	$node->command_ok(
 		[ 'createdb', $dbname ],


[parent: 797adaf0febe]