From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Tomas Vondra <tomas@vondra.me>
Cc: Christoph Berg <myon@debian.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
Date: Thu, 12 Feb 2026 19:42:20 +0200
Message-ID: <0aac5d44-0063-458d-8792-e9bbbc37fe72@iki.fi> (raw)
In-Reply-To: <aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal>
References: <21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5@iki.fi>
<202602121635.kdy5xdbvxaqi@alvherre.pgsql>
<aY4MpVrK++9oXvti@ip-10-97-1-34.eu-west-3.compute.internal>
On 12/02/2026 19:23, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Feb 12, 2026 at 05:43:47PM +0100, Álvaro Herrera wrote:
>> On 2026-Feb-12, Heikki Linnakangas wrote:
>>
>>> I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS into
>>> pg_numa_query_pages) made the function unusable in frontend programs,
>>> because CHECK_FOR_INTERRUPTS is server only.
>
> Good catch! Out of curiosity how did you find the issue? Were you building a
> client tool making used of pg_numa_query_pages()?
I was working on my "interrupts vs signals" patch, which needed to
change some #includes in pg_numa.c, when I spotted that it already had
that issue.
>> It's not used in frontend
>>> programs today, but it was placed in src/port/ with the idea that it could
>>> be.
>>
>> Your patch LGTM.
>
> +1
Pushed, thanks!
- Heikki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, bertranddrouvot.pg@gmail.com, alvherre@kurilemu.de, tomas@vondra.me, myon@debian.org, andres@anarazel.de, tomas.vondra@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
In-Reply-To: <0aac5d44-0063-458d-8792-e9bbbc37fe72@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox