From: Andres Freund <andres@anarazel.de>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: melanieplageman@gmail.com
Cc: ibrar.ahmad@gmail.com
Cc: masao.fujii@oss.nttdata.com
Cc: gkokolatos@protonmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: shared-memory based stats collector - v66
Date: Sat, 2 Apr 2022 01:21:02 -0700
Message-ID: <20220402082102.ojdd2e6cobsmljvh@alap3.anarazel.de> (raw)
In-Reply-To: <20220325.172418.1055357550509939415.horikyota.ntt@gmail.com>
References: <20220317073652.kz3uuh6le6vbfod4@alap3.anarazel.de>
<CAAKRu_YsFzW3jsQUD7MVUY8c+87OiKW_Y93TsPAfLr3zi_jX9w@mail.gmail.com>
<20220325.142256.1649716600998659084.horikyota.ntt@gmail.com>
<20220325.172418.1055357550509939415.horikyota.ntt@gmail.com>
Hi,
On 2022-03-25 17:24:18 +0900, Kyotaro Horiguchi wrote:
> > * AFIXME: Should all the stats drop code be moved into pgstat_drop.c?
>
> Or pgstat_xact.c?
I wasn't initially happy with that suggestion, but after running with it, it
looks pretty good.
I also moved a fair bit of code into pgstat_shm.c, which to me improved code
navigation a lot. I'm wondering about splitting it further even, into
pgstat_shm.c and pgstat_entry.c.
What do you think?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, horikyota.ntt@gmail.com, melanieplageman@gmail.com, ibrar.ahmad@gmail.com, masao.fujii@oss.nttdata.com, gkokolatos@protonmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: shared-memory based stats collector - v66
In-Reply-To: <20220402082102.ojdd2e6cobsmljvh@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox