agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: recovery modules
Date: Mon, 30 Jan 2023 12:04:22 -0800
Message-ID: <20230130200422.GA2797238@nathanxps13> (raw)
In-Reply-To: <20230130194810.6fztfgbn32e7qarj@awork3.anarazel.de>
References: <Y830qTRZJP6XGuOF@paquier.xyz>
	<20230123214428.GA572995@nathanxps13>
	<Y9Dbfe3C0wGJqyav@paquier.xyz>
	<20230128002319.362oxrxf7ardfz2a@awork3.anarazel.de>
	<20230128005910.GA2245287@nathanxps13>
	<20230128015542.baefifnqgpgtkij6@awork3.anarazel.de>
	<20230128041746.GA2288302@nathanxps13>
	<20230128062729.GA2570237@nathanxps13>
	<Y9d3Cmk0Vjg8cYmO@paquier.xyz>
	<20230130194810.6fztfgbn32e7qarj@awork3.anarazel.de>

On Mon, Jan 30, 2023 at 11:48:10AM -0800, Andres Freund wrote:
> I don't think _PG_archive_module_init() should actually allocate a memory
> context and do other similar initializations. Instead it should just return
> 'const ArchiveModuleCallbacks*', typically a single line.
> 
> Allocations etc should happen in one of the callbacks. That way we can
> actually have multiple instances of a module.

I think we'd need to invent a startup callback for archive modules for this
to work, but that's easy enough.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (90+ messages)  latest in thread

Message-ID: <20230130200422.GA2797238@nathanxps13>
Permalink:  ../20230130200422.GA2797238@nathanxps13/
Also on:    postgresql.org/message-id/20230130200422.GA2797238@nathanxps13

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, michael@paquier.xyz
  Subject: Re: recovery modules
  In-Reply-To: <20230130200422.GA2797238@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox