pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Cc: bungina@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
Date: Thu, 09 Nov 2023 15:30:56 +0900
Message-ID: <277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com> (raw)
In-Reply-To: <CAFh8B=nNJtm9ke4_1mhpwGz2PV9yoyF6hMnYh5XACt0AA4VG-A@mail.gmail.com>
References: <8b385bb6d5f87e54c1c6333fece0444a@oss.nttdata.com>
	<ZORIVnxs+lXoEAQG@paquier.xyz>
	<CAFh8B=k2DUwruBA3djsMf3b_wfqeN092iqaDcZYJ4PAgnne2KA@mail.gmail.com>
	<20230824.094538.2107929879048686192.horikyota.ntt@gmail.com>
	<bb706f8393c5207812268a5a2e3f98d7@oss.nttdata.com>
	<CAFh8B=m0TuTNyPzOC6zWrVH2iOEnuNyuPSazqTgjVbd=nt3B2Q@mail.gmail.com>
	<CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
	<763cac924055f1669578bea950c667c7@oss.nttdata.com>
	<CAFh8B=k80mdYeEZf6OMpQSMXa7rj5trwoGBVZv+7Lha900HpvQ@mail.gmail.com>
	<293cf2c14c149cb333dd30ae39e08e4e@oss.nttdata.com>
	<CAFh8B=nNJtm9ke4_1mhpwGz2PV9yoyF6hMnYh5XACt0AA4VG-A@mail.gmail.com>

On 2023-11-06 23:58, Alexander Kukushkin wrote:
> Hi Torikoshia,
> 
> On Thu, 2 Nov 2023 at 04:24, torikoshia <torikoshia@oss.nttdata.com>
> wrote:
> 
>>> +extern void preserve_file(char *filepath);
>> 
>> Is this necessary?
>> This function was defined in older version patch, but no longer
>> seems to
>> exist.
>> 
>> +# We use "perl -e 'exit(1)'" as a alternative to "false", because
>> the
>> last one
>> 'a' should be 'an'?
> 
> Thanks for the feedback
> 
> Please find the new version attached.
Thanks for the update!

I've set the CF entry to "Ready for Committer".

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation





view thread (50+ messages)  latest in thread

Message-ID: <277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com>
Permalink:  ../277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com/
Also on:    postgresql.org/message-id/277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: torikoshia@oss.nttdata.com, cyberdemn@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org, bungina@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_rewind WAL segments deletion pitfall
  In-Reply-To: <277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox