pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: create_help.pl treats <literal> as replaceable
Date: Mon, 23 May 2022 13:17:12 +0200
Message-ID: <9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com> (raw)
In-Reply-To: <20220519.111233.1054039569955825310.horikyota.ntt@gmail.com>
References: <1581685.1652800163@sss.pgh.pa.us>
	<20220518.095805.2164390691449974704.horikyota.ntt@gmail.com>
	<304e2c49-14b4-e93c-ff64-8a5a0d54e408@enterprisedb.com>
	<20220519.111233.1054039569955825310.horikyota.ntt@gmail.com>

On 19.05.22 04:12, Kyotaro Horiguchi wrote:
> At Wed, 18 May 2022 18:23:57 +0200, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote in
>> "Boolean" is correct; see <https://en.wiktionary.org/wiki/Boolean; for
>> example.
> 
> Ok, so, don't we in turn need to replace "boolean"s with "Boolean"?
> 
> "only boolean operators can have negators"
> "only boolean operators can have restriction selectivity"
> ...
> 
> And I'm not sure how to do with "bool". Should it be "Boolean" instead
> from the point of uniformity?
> 
> errmsg("only bool, numeric, and text types could be "

The SQL data type is called BOOLEAN, and we typically lower-case type 
names in PostgreSQL, so messages should be like

     column %s should be of type integer
     column %s should be of type boolean

As an adjective, not a type, it should be spelled Boolean, because 
that's how it's in the dictionary (cf. Gaussian).

     %s should have a string value
     %s should have a Boolean value

"bool" should normally not appear in user-facing messages, unless we are 
dealing with internal type names (cf. int4) or C types.

Of course, the lines between all of the above are blurry.





view thread (9+ messages)

Message-ID: <9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com>
Permalink:  ../9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com/
Also on:    postgresql.org/message-id/9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: create_help.pl treats <literal> as replaceable
  In-Reply-To: <9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox