agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed
From: Alberto Piai <alberto.piai@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix ALTER COLUMN ... DROP EXPRESSSION with subpartitions
Date: Tue, 04 Aug 2026 14:23:51 +0200
Message-ID: <DKG5NKRFZ4JS.35CSGGZ53YKYU@gmail.com> (raw)
In-Reply-To: <anGRnFgKM6RFmGLm@alvherre.pgsql>
References: <DHMT78XOD8BK.341V3H87KZ7NO@gmail.com>
	<anGRnFgKM6RFmGLm@alvherre.pgsql>

On Tue Aug 4, 2026 at 9:26 AM CEST, Álvaro Herrera wrote:
> Hello Alberto,
>
> On 2026-Apr-07, Alberto Piai wrote:
>
>> While working on [0], I noticed that DROP EXPRESSION currently refuses
>> to be applied to inheritance trees of depth > 2, e.g. when there are
>> subpartitions.
>
> Yep, confirmed.
>
>> PFA a fix for this and a test case.
>> 
>> I added the test case to generated_stored.sql,
>
> Looks good.  I pushed your fix, with two minor changes:

Thanks for pushing this, and for taking the time to explain your
improvements. Much appreciated!

>
> I think you didn't add a commitfest entry for this.

I created one a while back, for some reason it didn't pick up your
latest mail. But that's maybe because it's assigned to PG20-1 which is
closed now. Anyway I updated it, so that's wrapped up now :)


Alberto

-- 
Alberto Piai
Sensational AG
Zürich, Switzerland







view thread (3+ messages)

Message-ID: <DKG5NKRFZ4JS.35CSGGZ53YKYU@gmail.com>
Permalink:  ../DKG5NKRFZ4JS.35CSGGZ53YKYU@gmail.com/
Also on:    postgresql.org/message-id/DKG5NKRFZ4JS.35CSGGZ53YKYU@gmail.com

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alberto.piai@gmail.com, alvherre@kurilemu.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Fix ALTER COLUMN ... DROP EXPRESSSION with subpartitions
  In-Reply-To: <DKG5NKRFZ4JS.35CSGGZ53YKYU@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox