agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: cca5507 <cca5507@qq.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Do not lock tables in get_tables_to_repack
Date: Mon, 20 Jul 2026 12:19:52 +0200
Message-ID: <al31_DPTruXg2Tw7@alvherre.pgsql> (raw)
In-Reply-To: <tencent_3188B53829333244786E072B7611A1F48508@qq.com>
On 2026-Jul-11, cca5507 wrote:
> Bharath Rupireddy wrote:
> > + table_oid = IndexGetRelation(child_oid, true);
> > + if (!OidIsValid(table_oid))
> > + continue;
> >
> > How about a short comment on why this is needed even with a lock on
> > the parent, since that lock doesn't cover lower-level leaves in a
> > multi-level partition tree?
>
> I think it's worth a comment, too. Patch LGTM.
Thanks, added that and pushed.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"
view thread (10+ messages)
Message-ID: <al31_DPTruXg2Tw7@alvherre.pgsql>
Permalink: ../al31_DPTruXg2Tw7@alvherre.pgsql/
Also on: postgresql.org/message-id/al31_DPTruXg2Tw7@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, cca5507@qq.com, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Do not lock tables in get_tables_to_repack
In-Reply-To: <al31_DPTruXg2Tw7@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox