From: sergiyvamz (@sergiyvamz) <noreply+sergiyvamz@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2215: fix: check target driver for current transaction state
Date: Thu, 12 Nov 2026 16:53:09 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2215-rc4553529243@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2215-rc4449383563@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2215@github.com>
<gh-aws-aws-advanced-jdbc-wrapper-2215-rc4449383563@github.com>
(on wrapper/src/main/java/software/amazon/jdbc/targetdriverdialect/PgDriverHelper.java:149)
Yes. Both HikariCP's `ProxyConnection` and c3p0's proxy delegate `isWrapperFor`/`unwrap` to the inner driver connection, so the dialect reads the driver's own flag through the pool handle. One gap this turned up: Connector/J's `isWrapperFor` does not reject a closed connection (pgjdbc's does), so a closed or returned-to-pool handle could report stale state. Both helpers now check `isClosed()` first. `TransactionStateTests.test_internalConnectionPool_proxyPassesDriverStateThrough` covers the pooled path end to end.