From: sergiyvamz (@sergiyvamz) <noreply+sergiyvamz@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2215: fix: check target driver for current transaction state
Date: Mon, 16 Nov 2026 18:24:30 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2215-rc4589739657@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2215-rc4589515801@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2215@github.com>
<gh-aws-aws-advanced-jdbc-wrapper-2215-rc4589515801@github.com>
(on benchmarks/src/jmh/java/software/amazon/jdbc/benchmarks/PluginServiceBenchmarks.java:255)
I assume that these changes improve overall driver performance. All 3 major driver provides transaction flag out-of-the-box without additional SQL parsing or extra network call. Boxing/unboxing of Boolean definitely takes some extra time but it's negligible comparing to SQL parsing. But we did not run any comparison.