pg.ddx.io  aws/aws-advanced-jdbc-wrapper GitHub issues and pull requests  
help / color / mirror / Atom feed
From: aaron-congo (@aaron-congo) <noreply+aaron-congo@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2237: feat: add efm3 host monitoring plugin with per-connection registration
Date: Wed, 18 Nov 2026 22:00:30 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621444914@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2237@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2237@github.com>

(on wrapper/src/main/java/software/amazon/jdbc/plugin/efm/v3/HostMonitoringConnectionPluginV3.java:211)

When `identifyConnection` throws, the exception is rethrown and no slot is cached, so every later network-bound call runs identification again. If the failure is persistent, for example missing permissions for the host-id query or an engine or proxy that doesn't support it, every monitored call on that connection fails, so the connection can't be used at all. The javadoc on `getSlot` also says it "falls back to the endpoint itself when the host cannot be identified". The null case (e.g. RDS Proxy) does fall back, but the exception case doesn't.

Falling back to the endpoint may not be ideal either, since the probe follows DNS and, for reader or custom endpoints, can check a different instance than the one the connection is on. Could the plugin instead log a warning, remember that this connection can't be monitored, and pass its calls through unmonitored until the connection changes? That keeps the connection usable, stops identification from being retried on every call, and the monitor never acts on the wrong host's health. If identification is meant to be required, failing during `connect` would be clearer than failing on the first query.


view thread (39+ messages)  latest in thread

Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621444914@github.com>
Permalink:  ../gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621444914@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox