pg.ddx.io  aws/aws-advanced-jdbc-wrapper GitHub issues and pull requests  
help / color / mirror / Atom feed
From: aaron-congo (@aaron-congo) <noreply+aaron-congo@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2237: feat: add efm3 host monitoring plugin with per-connection registration
Date: Wed, 18 Nov 2026 22:22:14 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621672746@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2237@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2237@github.com>

(on wrapper/src/main/java/software/amazon/jdbc/plugin/efm/v3/HostMonitorServiceV3Impl.java)

nit: `monitorDisposalTime` is now defined three times (V1, V2, and here) with the same name, default, and description. `HostMonitorV3Impl.buildMonitoringProperties` and `checkConnectionStatus` also largely repeat efm2's `monitoring-` prefix handling and probe logic. Reusing the existing property (or moving it to `HostMonitoringConnectionBasePlugin`) and extracting the shared property and probe code into `efm.base` would keep a future fix in one plugin from missing the others.


view thread (39+ messages)  latest in thread

Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621672746@github.com>
Permalink:  ../gh-aws-aws-advanced-jdbc-wrapper-2237-rc4621672746@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox