From: aaron-congo (@aaron-congo) <noreply+aaron-congo@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: Re: [aws/aws-advanced-jdbc-wrapper] PR #2253: fix: map KMS parameters per table in multi-table statements, and refuse MySQL executable comments that change placeholders
Date: Thu, 19 Nov 2026 19:06:52 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2253-rc4633686921@github.com> (raw)
In-Reply-To: <gh-aws-aws-advanced-jdbc-wrapper-2253-rc4622740376@github.com>
References: <gh-aws-aws-advanced-jdbc-wrapper-2253@github.com>
<gh-aws-aws-advanced-jdbc-wrapper-2253-rc4622740376@github.com>
(on wrapper/src/main/java/software/amazon/jdbc/plugin/sqlparser/SqlParserConnectionPlugin.java)
Good point, thanks. Merging by last segment and ignoring case was only meant to stop `public.users` and `users` (the same table, reported once by the mapper and once by JSqlParser's table finder) from counting as two tables, but it also merged genuinely different tables. I've changed it to count only the table finder's names, compared exactly (no case folding, schema kept), and to use the bare name only when exactly one table remains. `a.users JOIN b.users` and `"Users" JOIN users` now leave a bare annotation unresolved, so it isn't encrypted and is reported as unmapped in a write.