pg.ddx.io  aws/aws-advanced-jdbc-wrapper GitHub issues and pull requests  
help / color / mirror / Atom feed
From: sergiyvamz (@sergiyvamz) <noreply+sergiyvamz@github.com>
To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>
Subject: [aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService
Date: Wed, 18 Nov 2026 16:32:22 +0000
Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2255@github.com> (raw)

The Snapshot to Maven build on main fails in `:aws-advanced-jdbc-wrapper:javadoc` with `reference not found` at `PluginService.java:189`. #2215 moved `setInTransaction(boolean)` from `PluginService` to `PluginManagerService`, but the `isInTransaction()` javadoc still links to `#setInTransaction(boolean)`. This points the link at `PluginManagerService#setInTransaction(boolean)`.

Failing run: https://github.com/aws/aws-advanced-jdbc-wrapper/actions/runs/44184949095

inline patch 1: wrapper/src/main/java/software/amazon/jdbc/PluginService.java (+1/-1 lines) download inline-1.patchdiff --git a/wrapper/src/main/java/software/amazon/jdbc/PluginService.java b/wrapper/src/main/java/software/amazon/jdbc/PluginService.java index 8e32cf5eb..090a2fbc4 100644 --- a/wrapper/src/main/java/software/amazon/jdbc/PluginService.java +++ b/wrapper/src/main/java/software/amazon/jdbc/PluginService.java @@ -186,7 +186,7 @@ HostSpec getHostSpecByStrategy(List<HostSpec> hosts, @Nullable HostRole role, St * <p>Calls the target driver dialect to check if the target connection is inside a transaction, * {@link software.amazon.jdbc.targetdriverdialect.TargetDriverDialect#isInTransaction(Connection)}. * If unknown, check the parsed state from the SQL and the JDBC calls recorded via - * {@link #setInTransaction(boolean)}. + * {@link PluginManagerService#setInTransaction(boolean)}. * * <p>The SQL is only parsed while the driver reports nothing for the connection. While it does * report, {@link software.amazon.jdbc.plugin.DefaultConnectionPlugin} records the driver's answer

view thread (4+ messages)  latest in thread

Message-ID: <gh-aws-aws-advanced-jdbc-wrapper-2255@github.com>
Permalink:  ../gh-aws-aws-advanced-jdbc-wrapper-2255@github.com/

 ·  · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox