pg.ddx.io  aws/aws-advanced-jdbc-wrapper GitHub issues and pull requests  
help / color / mirror / Atom feed
[aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService
4+ messages / 2 participants
[nested] [flat]

* [aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService
@ 2026-11-18 16:32 "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  0 siblings, 0 replies; 4+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 16:32 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

The Snapshot to Maven build on main fails in `:aws-advanced-jdbc-wrapper:javadoc` with `reference not found` at `PluginService.java:189`. #2215 moved `setInTransaction(boolean)` from `PluginService` to `PluginManagerService`, but the `isInTransaction()` javadoc still links to `#setInTransaction(boolean)`. This points the link at `PluginManagerService#setInTransaction(boolean)`.

Failing run: https://github.com/aws/aws-advanced-jdbc-wrapper/actions/runs/44184949095

inline patch 1: wrapper/src/main/java/software/amazon/jdbc/PluginService.java (+1/-1 lines) download inline-1.patchdiff --git a/wrapper/src/main/java/software/amazon/jdbc/PluginService.java b/wrapper/src/main/java/software/amazon/jdbc/PluginService.java index 8e32cf5eb..090a2fbc4 100644 --- a/wrapper/src/main/java/software/amazon/jdbc/PluginService.java +++ b/wrapper/src/main/java/software/amazon/jdbc/PluginService.java @@ -186,7 +186,7 @@ HostSpec getHostSpecByStrategy(List<HostSpec> hosts, @Nullable HostRole role, St * <p>Calls the target driver dialect to check if the target connection is inside a transaction, * {@link software.amazon.jdbc.targetdriverdialect.TargetDriverDialect#isInTransaction(Connection)}. * If unknown, check the parsed state from the SQL and the JDBC calls recorded via - * {@link #setInTransaction(boolean)}. + * {@link PluginManagerService#setInTransaction(boolean)}. * * <p>The SQL is only parsed while the driver reports nothing for the connection. While it does * report, {@link software.amazon.jdbc.plugin.DefaultConnectionPlugin} records the driver's answer
^ permalink raw [nested|flat] 4+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2255 (approved): fix: broken javadoc link to setInTransaction in PluginService
@ 2026-11-18 16:52 ` "aaron-congo (@aaron-congo)" <noreply+aaron-congo@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: aaron-congo (@aaron-congo) @ 2026-11-18 16:52 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>



^ permalink  raw  [nested|flat] 4+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService
@ 2026-11-18 16:52 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 16:52 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz closed this.

^ permalink  raw  [nested|flat] 4+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService
@ 2026-11-18 16:52 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 16:52 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz merged this (commit 971aca5a8eff).

^ permalink  raw  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2026-11-18 16:52 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 16:32 [aws/aws-advanced-jdbc-wrapper] PR #2255: fix: broken javadoc link to setInTransaction in PluginService "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 16:52 ` Re: [aws/aws-advanced-jdbc-wrapper] PR #2255 (approved): fix: broken javadoc link to setInTransaction in PluginService "aaron-congo (@aaron-congo)" <noreply+aaron-congo@github.com>
2026-11-18 16:52 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 16:52 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox