public inbox for [email protected]
help / color / mirror / Atom feedgit failures
12+ messages / 4 participants
[nested] [flat]
* git failures
@ 2017-01-03 22:16 Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
0 siblings, 1 reply; 12+ messages in thread
From: Andrew Dunstan @ 2017-01-03 22:16 UTC (permalink / raw)
To: [email protected]; [email protected]; [email protected]; +Cc: buildfarm-members
Recently a number of git failures have been seen like this:
*** Please tell me who you are.
Run
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident <[email protected]
> not allowed
Notably on Debian/Ubuntu machines. I assume they have had some sort of
recent git update.
Why it should care if you're not committing anything is beyond me. It
seems quite pointless. However, It seems like the account you're running
the buildfarm animal as needs a name and email address set to avoid this
issue.
This applies particularly to members spurfowl, ibex and termite. Please
fix them urgently so the failures email list doesn't get spammed.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
@ 2017-01-03 22:21 ` Tom Lane <[email protected]>
2017-01-03 22:46 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
0 siblings, 2 replies; 12+ messages in thread
From: Tom Lane @ 2017-01-03 22:21 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; +Cc: [email protected]; [email protected]; [email protected]; buildfarm-members
Andrew Dunstan <[email protected]> writes:
> Recently a number of git failures have been seen like this:
> *** Please tell me who you are.
> Notably on Debian/Ubuntu machines. I assume they have had some sort of
> recent git update.
No, I do not think it's the fault of the buildfarm machines. The problem
is that Magnus got rid of a bad commit into the 9.2 branch via "git reset"
not "git revert", cf
https://www.postgresql.org/message-id/CABUevEzrD-BYtQOQ22navkoWquOC5TcqPcBS_iQ2cYqaK9_39g%40mail.gma...
and these three machines seem to have been quick enough to see the
intermediate state and get confused by it. I'm not very sure why "git
pull" isn't enough to recover, but it evidently isn't.
regards, tom lane
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
@ 2017-01-03 22:46 ` Stephen Frost <[email protected]>
1 sibling, 0 replies; 12+ messages in thread
From: Stephen Frost @ 2017-01-03 22:46 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; +Cc: buildfarm-members; [email protected]; [email protected]
Andrew, Tom,
Out of the office currently but will address as soon as I'm able to.
Thanks!
Stephen
On Tue, Jan 3, 2017 at 17:21 Tom Lane <[email protected]> wrote:
> Andrew Dunstan <[email protected]> writes:
>
> > Recently a number of git failures have been seen like this:
>
> > *** Please tell me who you are.
>
> > Notably on Debian/Ubuntu machines. I assume they have had some sort of
>
> > recent git update.
>
>
>
> No, I do not think it's the fault of the buildfarm machines. The problem
>
> is that Magnus got rid of a bad commit into the 9.2 branch via "git reset"
>
> not "git revert", cf
>
>
>
>
> https://www.postgresql.org/message-id/CABUevEzrD-BYtQOQ22navkoWquOC5TcqPcBS_iQ2cYqaK9_39g%40mail.gma...
>
>
>
> and these three machines seem to have been quick enough to see the
>
> intermediate state and get confused by it. I'm not very sure why "git
>
> pull" isn't enough to recover, but it evidently isn't.
>
>
>
> regards, tom lane
>
>
>
>
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
@ 2017-01-04 00:08 ` Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
1 sibling, 1 reply; 12+ messages in thread
From: Andrew Dunstan @ 2017-01-04 00:08 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: [email protected]; [email protected]; [email protected]; buildfarm-members
On 01/03/2017 05:21 PM, Tom Lane wrote:
> Andrew Dunstan <[email protected]> writes:
>> Recently a number of git failures have been seen like this:
>> *** Please tell me who you are.
>> Notably on Debian/Ubuntu machines. I assume they have had some sort of
>> recent git update.
> No, I do not think it's the fault of the buildfarm machines. The problem
> is that Magnus got rid of a bad commit into the 9.2 branch via "git reset"
> not "git revert", cf
>
> https://www.postgresql.org/message-id/CABUevEzrD-BYtQOQ22navkoWquOC5TcqPcBS_iQ2cYqaK9_39g%40mail.gma...
>
> and these three machines seem to have been quick enough to see the
> intermediate state and get confused by it. I'm not very sure why "git
> pull" isn't enough to recover, but it evidently isn't.
Yeah, axolotl just failed :-(
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
@ 2017-01-04 01:04 ` Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 05:05 ` Re: git failures Craig Ringer <[email protected]>
0 siblings, 2 replies; 12+ messages in thread
From: Stephen Frost @ 2017-01-04 01:04 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; +Cc: buildfarm-members; [email protected]; [email protected]
All,
I'm hopeful that I fixed it....
Thanks!
Stephen
On Tue, Jan 3, 2017 at 19:09 Andrew Dunstan <[email protected]>
wrote:
>
>
>
>
> On 01/03/2017 05:21 PM, Tom Lane wrote:
>
> > Andrew Dunstan <[email protected]> writes:
>
> >> Recently a number of git failures have been seen like this:
>
> >> *** Please tell me who you are.
>
> >> Notably on Debian/Ubuntu machines. I assume they have had some sort of
>
> >> recent git update.
>
> > No, I do not think it's the fault of the buildfarm machines. The problem
>
> > is that Magnus got rid of a bad commit into the 9.2 branch via "git
> reset"
>
> > not "git revert", cf
>
> >
>
> >
> https://www.postgresql.org/message-id/CABUevEzrD-BYtQOQ22navkoWquOC5TcqPcBS_iQ2cYqaK9_39g%40mail.gma...
>
> >
>
> > and these three machines seem to have been quick enough to see the
>
> > intermediate state and get confused by it. I'm not very sure why "git
>
> > pull" isn't enough to recover, but it evidently isn't.
>
>
>
>
>
> Yeah, axolotl just failed :-(
>
>
>
> cheers
>
>
>
> andrew
>
>
>
> --
>
> Andrew Dunstan https://www.2ndQuadrant.com
>
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
>
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
@ 2017-01-04 01:24 ` Tom Lane <[email protected]>
2017-01-04 01:32 ` Re: git failures Stephen Frost <[email protected]>
1 sibling, 1 reply; 12+ messages in thread
From: Tom Lane @ 2017-01-04 01:24 UTC (permalink / raw)
To: Stephen Frost <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; buildfarm-members; [email protected]; [email protected]
Stephen Frost <[email protected]> writes:
> I'm hopeful that I fixed it....
For the benefit of the other people with this problem ... what did you do?
regards, tom lane
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
@ 2017-01-04 01:32 ` Stephen Frost <[email protected]>
2017-01-04 02:15 ` Re: git failures Andrew Dunstan <[email protected]>
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Frost @ 2017-01-04 01:32 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; buildfarm-members; [email protected]; [email protected]
On Tue, Jan 3, 2017 at 20:25 Tom Lane <[email protected]> wrote:
> Stephen Frost <[email protected]> writes:
>
> > I'm hopeful that I fixed it....
>
>
>
> For the benefit of the other people with this problem ... what did you do?
>
I did a git pull in the REL9_2_STABLE/pgsql directory and accepted the
merge commit message.
I'm not convinced that was really the "right" or "correct" thing to do, but
it seemed to allow subsequent git pull's without erroring or asking for any
user interaction.
Will look into it more tomorrow.
Thanks!
Stephen
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 01:32 ` Re: git failures Stephen Frost <[email protected]>
@ 2017-01-04 02:15 ` Andrew Dunstan <[email protected]>
2017-01-04 04:55 ` Re: git failures Craig Ringer <[email protected]>
0 siblings, 1 reply; 12+ messages in thread
From: Andrew Dunstan @ 2017-01-04 02:15 UTC (permalink / raw)
To: Stephen Frost <[email protected]>; Tom Lane <[email protected]>; +Cc: buildfarm-members; [email protected]; [email protected]
On 01/03/2017 08:32 PM, Stephen Frost wrote:
>
> On Tue, Jan 3, 2017 at 20:25 Tom Lane <[email protected]
> <mailto:[email protected]>> wrote:
>
> Stephen Frost <[email protected] <mailto:[email protected]>> writes:
>
> > I'm hopeful that I fixed it....
>
>
>
> For the benefit of the other people with this problem ... what did
> you do?
>
>
> I did a git pull in the REL9_2_STABLE/pgsql directory and accepted the
> merge commit message.
>
> I'm not convinced that was really the "right" or "correct" thing to
> do, but it seemed to allow subsequent git pull's without erroring or
> asking for any user interaction.
>
> Will look into it more tomorrow.
>
That didn't work for me. I removed that directory altogether, and I
expect the next buildfarm run to rebuild it cleanly.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 01:32 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 02:15 ` Re: git failures Andrew Dunstan <[email protected]>
@ 2017-01-04 04:55 ` Craig Ringer <[email protected]>
2017-01-04 13:26 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 13:43 ` Re: git failures Andrew Dunstan <[email protected]>
0 siblings, 2 replies; 12+ messages in thread
From: Craig Ringer @ 2017-01-04 04:55 UTC (permalink / raw)
To: Andrew Dunstan <[email protected]>; +Cc: Stephen Frost <[email protected]>; Tom Lane <[email protected]>; buildfarm-members; [email protected]
On 4 January 2017 at 10:15, Andrew Dunstan
<[email protected]> wrote:
>
>
> On 01/03/2017 08:32 PM, Stephen Frost wrote:
>>
>>
>> On Tue, Jan 3, 2017 at 20:25 Tom Lane <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>> Stephen Frost <[email protected] <mailto:[email protected]>> writes:
>>
>> > I'm hopeful that I fixed it....
>>
>>
>>
>> For the benefit of the other people with this problem ... what did
>> you do?
>>
>>
>> I did a git pull in the REL9_2_STABLE/pgsql directory and accepted the
>> merge commit message.
>>
>> I'm not convinced that was really the "right" or "correct" thing to do,
>> but it seemed to allow subsequent git pull's without erroring or asking for
>> any user interaction.
>>
>> Will look into it more tomorrow.
>>
>
>
> That didn't work for me. I removed that directory altogether, and I expect
> the next buildfarm run to rebuild it cleanly.
It's definitely not the right thing.
You should remove the clone, or
git reset --hard origin/REL9_2_STABLE
it.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 01:32 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 02:15 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 04:55 ` Re: git failures Craig Ringer <[email protected]>
@ 2017-01-04 13:26 ` Stephen Frost <[email protected]>
1 sibling, 0 replies; 12+ messages in thread
From: Stephen Frost @ 2017-01-04 13:26 UTC (permalink / raw)
To: Craig Ringer <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; buildfarm-members; [email protected]
* Craig Ringer ([email protected]) wrote:
> On 4 January 2017 at 10:15, Andrew Dunstan
> <[email protected]> wrote:
> >
> >
> > On 01/03/2017 08:32 PM, Stephen Frost wrote:
> >>
> >>
> >> On Tue, Jan 3, 2017 at 20:25 Tom Lane <[email protected]
> >> <mailto:[email protected]>> wrote:
> >>
> >> Stephen Frost <[email protected] <mailto:[email protected]>> writes:
> >>
> >> > I'm hopeful that I fixed it....
> >>
> >>
> >>
> >> For the benefit of the other people with this problem ... what did
> >> you do?
> >>
> >>
> >> I did a git pull in the REL9_2_STABLE/pgsql directory and accepted the
> >> merge commit message.
> >>
> >> I'm not convinced that was really the "right" or "correct" thing to do,
> >> but it seemed to allow subsequent git pull's without erroring or asking for
> >> any user interaction.
> >>
> >> Will look into it more tomorrow.
> >>
> >
> >
> > That didn't work for me. I removed that directory altogether, and I expect
> > the next buildfarm run to rebuild it cleanly.
>
> It's definitely not the right thing.
>
> You should remove the clone, or
>
> git reset --hard origin/REL9_2_STABLE
>
> it.
Yeah, seems like that was necessary. I've done that now and it seems
happier.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (819B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 01:24 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 01:32 ` Re: git failures Stephen Frost <[email protected]>
2017-01-04 02:15 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 04:55 ` Re: git failures Craig Ringer <[email protected]>
@ 2017-01-04 13:43 ` Andrew Dunstan <[email protected]>
1 sibling, 0 replies; 12+ messages in thread
From: Andrew Dunstan @ 2017-01-04 13:43 UTC (permalink / raw)
To: Craig Ringer <[email protected]>; +Cc: Stephen Frost <[email protected]>; Tom Lane <[email protected]>; buildfarm-members; [email protected]
On 01/03/2017 11:55 PM, Craig Ringer wrote:
>>
>>
>> That didn't work for me. I removed that directory altogether, and I expect
>> the next buildfarm run to rebuild it cleanly.
> It's definitely not the right thing.
>
> You should remove the clone, or
>
> git reset --hard origin/REL9_2_STABLE
>
This seems to be the only reliable fix. Even removing the directory
didn't work where it's a linked workdir.
Thanks, Craig!
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: git failures
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Re: git failures Tom Lane <[email protected]>
2017-01-04 00:08 ` Re: git failures Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Re: git failures Stephen Frost <[email protected]>
@ 2017-01-04 05:05 ` Craig Ringer <[email protected]>
1 sibling, 0 replies; 12+ messages in thread
From: Craig Ringer @ 2017-01-04 05:05 UTC (permalink / raw)
To: Stephen Frost <[email protected]>; +Cc: Andrew Dunstan <[email protected]>; Tom Lane <[email protected]>; buildfarm-members; [email protected]
Termite is fixed.
Reset to 83a25a5209d93615e6d5f3eee4ef649853478498
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via buildfarm-members mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/buildfarm-members
^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2017-01-04 13:43 UTC | newest]
Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 22:16 git failures Andrew Dunstan <[email protected]>
2017-01-03 22:21 ` Tom Lane <[email protected]>
2017-01-03 22:46 ` Stephen Frost <[email protected]>
2017-01-04 00:08 ` Andrew Dunstan <[email protected]>
2017-01-04 01:04 ` Stephen Frost <[email protected]>
2017-01-04 01:24 ` Tom Lane <[email protected]>
2017-01-04 01:32 ` Stephen Frost <[email protected]>
2017-01-04 02:15 ` Andrew Dunstan <[email protected]>
2017-01-04 04:55 ` Craig Ringer <[email protected]>
2017-01-04 13:26 ` Stephen Frost <[email protected]>
2017-01-04 13:43 ` Andrew Dunstan <[email protected]>
2017-01-04 05:05 ` Craig Ringer <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox