From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
Date: Wed, 1 Jun 2022 16:11:16 +0200
Message-ID: <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com> (raw)
In-Reply-To: <YpXA7XHZtunxalTr@paquier.xyz>
References: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
<Yo/mWGJjCHOH3eB1@paquier.xyz>
<20220526205218.GC19626@telsasoft.com>
<Yo/5MlXbwY4UhMnm@paquier.xyz>
<2464542.1653603596@sss.pgh.pa.us>
<YpAMBqPrusng47e0@paquier.xyz>
<2480063.1653609068@sss.pgh.pa.us>
<YpAV1y8CUXGGkPJQ@paquier.xyz>
<20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
<3131727.1653768841@sss.pgh.pa.us>
<YpXA7XHZtunxalTr@paquier.xyz>
On 31.05.22 09:17, Michael Paquier wrote:
> On Sat, May 28, 2022 at 04:14:01PM -0400, Tom Lane wrote:
>> Yeah, I'd noticed the obsoleted comments too, but not bothered to complain
>> since that was just WIP and not an officially proposed patch. I'll be
>> happy to review if you want to put up a full patch.
> Well, here is a formal patch set, then. Please feel free to comment.
>
> FWIW, I am on the fence with dropping TESTDIR, as it could be used by
> out-of-core test code as well. If there are doubts about
> back-patching the first part, doing that only on HEAD would be fine to
> fix the problem of this thread.
I don't understand the point of this first patch at all. Why define
TESTOUTDIR as a separate variable if it's always TESTDIR + tmp_check?
Why define TESTOUTDIR in pg_regress invocations, if nothing uses it? If
you want it as a separate variable, it could be defined in some Per
utility module, but I don't see why it needs to be in Makefile.global.
What is the problem that this is trying to solve?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, andres@anarazel.de, pryzby@telsasoft.com
Subject: Re: pg_upgrade test writes to source directory
In-Reply-To: <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox