pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Zhihong Yu <zyu@yugabyte.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Stark <stark@mit.edu>
Cc: Pavel Trukhanov <pavel.trukhanov@gmail.com>
Subject: Re: pg_stat_statements and "IN" conditions
Date: Thu, 18 Mar 2021 09:38:09 -0400
Message-ID: <ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net> (raw)
In-Reply-To: <CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>
References: <CA+q6zcWtUbT_Sxj0V6HY6EZ89uv5wuG5aefpe_9n0Jr3VwntFg@mail.gmail.com>
	<20201118160432.hyko73sqc2bf7nkj@localhost>
	<20201226104635.uvzkftzu72zg5qux@localhost>
	<CALNJ-vQx7u-Nq_wVun72CVrHe4DcGfEurj_ikckJrRy2Pem=JA@mail.gmail.com>
	<20210105125230.etgmgixnn6fmpszl@localhost>
	<CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>

On 1/5/21 10:51 AM, Zhihong Yu wrote:
> 
> +   int         lastExprLenght = 0;
> 
> Did you mean to name the variable lastExprLenghth ?
> 
> w.r.t. extracting to helper method, the second and third 
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.

Dmitry, thoughts on this review?

Regards,
-- 
-David
david@pgmasters.net





view thread (155+ messages)  latest in thread

Message-ID: <ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net>
Permalink:  ../ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net/
Also on:    postgresql.org/message-id/ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, zyu@yugabyte.com, 9erthalion6@gmail.com, tgl@sss.pgh.pa.us, stark@mit.edu, pavel.trukhanov@gmail.com
  Subject: Re: pg_stat_statements and "IN" conditions
  In-Reply-To: <ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox