pg.ddx.io  reorg/pg_repack GitHub issues and pull requests  
help / color / mirror / Atom feed
From: za-arthur (@za-arthur) <noreply+za-arthur@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #481: pg_repack is aborted with error if a publication FOR ALL TABLES exist
Date: Thu, 19 Mar 2026 11:54:46 +0000
Message-ID: <gh-reorg-pg_repack-481-rc2959559159@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-481@github.com>
References: <gh-reorg-pg_repack-481@github.com>

(on bin/pg_repack.c)

I suggest a minor change of formatting, mainly changing white spaces to tabs (which is used by most of the code):
```suggestion
	/*
	 * repack will be aborted with error like
	 *
	 * ERROR:  cannot update table "table_16388" because it does not
	 * have a replica identity and publishes updates
	 *
	 * if a publication FOR ALL TABLES exists and apply_log requires
	 * deleting or updating a row in a temp table. To make this works,
	 * we need to set NOT NULL on columns of primary key and command
	 *
	 * ALTER TABLE repack.table_' || R.oid || ' REPLICA IDENTITY USING INDEX index_' || PK.indexrelid
	 *
	 * In addition, repack might break subscribers of this publication.
	 * For now, we simply refuse to continue.
	 */
	if (PQserverVersion(connection) >= 100000 && !no_error_on_publication)
	{
		res = execute_elevel("SELECT pubname FROM pg_publication WHERE puballtables LIMIT 1",
			0, NULL, DEBUG2);
		if (PQresultStatus(res) == PGRES_TUPLES_OK)
		{
			if (PQntuples(res) > 0)
			{
				const char *pubname;
				pubname = getstr(res, 0, 0);
				snprintf(errbuf, errsize, "publication \"%s\" FOR ALL TABLES found: won't be able to apply concurrent UPDATE and DELETE", pubname);
				goto cleanup;
			}
			/* no publications, continue to work */
		} else {
			if (errbuf)
				snprintf(errbuf, errsize, "%s", PQerrorMessage(connection));
			goto cleanup;
		}
		CLEARPGRES(res);
	}
```

view thread (9+ messages)  latest in thread

Message-ID: <gh-reorg-pg_repack-481-rc2959559159@github.com>
Permalink:  ../gh-reorg-pg_repack-481-rc2959559159@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox