From: CyberDem0n (@CyberDem0n) <noreply+CyberDem0n@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #493: Use format() and pg_catalog-qualified catalog tables in pg_repack.sql.in
Date: Thu, 12 Nov 2026 10:48:07 +0000
Message-ID: <gh-reorg-pg_repack-493-c6821518609@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-493@github.com>
References: <gh-reorg-pg_repack-493@github.com>
@ritojoao I am not a maintainer, and don't know what they would prefer.
What caught my eye is unqualified format() calls, which could be easily shadowed by creating function with the same name and better fitted arguments (for example format(text, text)) in lets say public schema. That opens up a very simple way for SQL injections.