pg.ddx.io  reorg/pg_repack GitHub issues and pull requests  
help / color / mirror / Atom feed
From: za-arthur (@za-arthur) <noreply+za-arthur@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #493: Use format() and pg_catalog-qualified catalog tables in pg_repack.sql.in
Date: Thu, 12 Nov 2026 11:01:16 +0000
Message-ID: <gh-reorg-pg_repack-493-c6821783653@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-493@github.com>
References: <gh-reorg-pg_repack-493@github.com>

I was working on using `format()` in this PR https://github.com/reorg/pg_repack/pull/482/commits. Although it wasn't merged yet, since it has much bigger changes than just using `format()`.

I think there is no need to use pg_catalog-qualified names (although I created https://github.com/reorg/pg_repack/issues/369 which has this point) since pg_repack sets `search_path = pg_catalog, pg_temp, public` on every connection:
https://github.com/reorg/pg_repack/blob/eaa601410ab2331dde45f7758fd248bf15784709/bin/pg_repack.c#L60...
https://github.com/reorg/pg_repack/blob/eaa601410ab2331dde45f7758fd248bf15784709/bin/pgut/pgut.c#L55...
https://github.com/reorg/pg_repack/blob/eaa601410ab2331dde45f7758fd248bf15784709/bin/pgut/pgut-fe.c#...

Also as Alexander pointed out functions like `format()`, `coalesce()`, `string_agg()` as well as operators (`=`, `>`) are also not used with fully qualified names.

It might make sense to search_path on every function if we want to make calls of that function by other clients other than by pg_repack itself.

view thread (21+ messages)  latest in thread

Message-ID: <gh-reorg-pg_repack-493-c6821783653@github.com>
Permalink:  ../gh-reorg-pg_repack-493-c6821783653@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox