pg.ddx.io  reorg/pg_repack GitHub issues and pull requests  
help / color / mirror / Atom feed
From: za-arthur (@za-arthur) <noreply+za-arthur@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #493: Use format() and pg_catalog-qualified catalog tables in pg_repack.sql.in
Date: Thu, 12 Nov 2026 20:33:36 +0000
Message-ID: <gh-reorg-pg_repack-493-c6835213706@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-493@github.com>
References: <gh-reorg-pg_repack-493@github.com>

I'm going to merge the PR with the following follow up issues I identified so far:
- `repack_apply()` can be broken in some rare cases with the error since it won't be able to find index operators (https://github.com/reorg/pg_repack/pull/495):
```
ERROR: query failed: ERROR:  operator does not exist: ext.hstore = ext.hstore
QUERY:  UPDATE repack.table_24121 SET (id, v) = ($2.id, $2.v) WHERE (id) = ($1.id)
```
- ~~Add `schema = repack` to `pg_repack.control`: postgres will install extension with limited `search_path`~~
- Consider limiting installation schema by adding `schema = pg_catalog` to `pg_repack.control`
- `SET LOCAL search_path = pg_catalog, pg_temp;` at the beginning of the installation script
- Consider removing `public` from `search_path` in `pg_repack`'s client code in `bin/pg_repack.c`, `bin/pgut/pgut.c`, `bin/pgut/pgut-fe.c`

view thread (21+ messages)  latest in thread

Message-ID: <gh-reorg-pg_repack-493-c6835213706@github.com>
Permalink:  ../gh-reorg-pg_repack-493-c6835213706@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox