From: CyberDem0n (@CyberDem0n) <noreply+CyberDem0n@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #493: Use format() and pg_catalog-qualified catalog tables in pg_repack.sql.in
Date: Fri, 13 Nov 2026 10:55:58 +0000
Message-ID: <gh-reorg-pg_repack-493-c6850823294@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-493@github.com>
References: <gh-reorg-pg_repack-493@github.com>
@za-arthur
> `SET LOCAL search_path = pg_catalog, pg_temp;` at the beginning of the installation script
You'll get `WARNING: SET LOCAL can only be used in transaction blocks`, and `search_path` will remain unchanged.
PG already does enough to harden search_path for extension creation/update: https://github.com/postgres/postgres/blob/77bba5454f96e626651449780e1614892557c1bc/src/backend/comma...
The only we need to do - use `schema = pg_catalog` in pg_repack.control. This schema already exists, and owned by bootstrap superuser.
> removing `public` from `search_path` in pg_repack's client code
Yes, this is a good one.