pg.ddx.io  reorg/pg_repack GitHub issues and pull requests  
help / color / mirror / Atom feed
From: za-arthur (@za-arthur) <noreply+za-arthur@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #493: Use format() and pg_catalog-qualified catalog tables in pg_repack.sql.in
Date: Fri, 13 Nov 2026 11:21:51 +0000
Message-ID: <gh-reorg-pg_repack-493-c6851353579@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-493@github.com>
References: <gh-reorg-pg_repack-493@github.com>

> PG already does enough to harden search_path for extension creation/update: https://github.com/postgres/postgres/blob/77bba5454f96e626651449780e1614892557c1bc/src/backend/comma...

If I understand correctly this hardening, Postgres adds a schema name, where pg_repack is installed to, to search_path. So if it is installed into `public` then search_path will be `public, pg_temp`.

> The only we need to do - use schema = pg_catalog in pg_repack.control. This schema already exists, and owned by bootstrap superuser.

I think we don't need to do that, since it will force installation of pg_repack into `pg_repack`, which might not work for everybody.

view thread (21+ messages)  latest in thread

Message-ID: <gh-reorg-pg_repack-493-c6851353579@github.com>
Permalink:  ../gh-reorg-pg_repack-493-c6851353579@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox