pg.ddx.io reorg/pg_repack GitHub issues and pull requests
help / color / mirror / Atom feedFrom: za-arthur (@za-arthur) <noreply+za-arthur@github.com>
To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>
Subject: Re: [reorg/pg_repack] PR #496: Harden client code queries and generated SQL against search_path
Date: Fri, 20 Nov 2026 21:54:42 +0000
Message-ID: <gh-reorg-pg_repack-496-rc4648153435@github.com> (raw)
In-Reply-To: <gh-reorg-pg_repack-496-rc4647235391@github.com>
References: <gh-reorg-pg_repack-496@github.com>
<gh-reorg-pg_repack-496-rc4647235391@github.com>
(on bin/pg_repack.c:2293)
Isn't guaranteed (see [PQescapeInternal](https://github.com/postgres/postgres/blob/REL_19_0/src/interfaces/libpq/fe-exec.c#L4250) implementation), and later `quoted_schema` is used when it isn't NULL:
```
quoted_schema ? quoted_schema : schema_name
```
But it is unlikely I suppose since `schema_name` is retrieved from the query:
https://github.com/reorg/pg_repack/blob/c9555033d2b618c1c25d38b6e48cfdff7e538ca5/bin/pg_repack.c#L24...
view thread (8+ messages) latest in thread
Message-ID: <gh-reorg-pg_repack-496-rc4648153435@github.com>
Permalink: ../gh-reorg-pg_repack-496-rc4648153435@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox