public inbox for [email protected]  

help / color / mirror / Atom feed

From: Christoph Berg <[email protected]>
To: Dave Page <[email protected]>
Cc: Syed Fahar Abbas <[email protected]>
Cc: Devrim GÜNDÜZ <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin v3.1 candidate builds and source...
Date: Thu, 28 Jun 2018 13:47:06 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
References: <CA+OCxow1BDDXK9K1d-pnSAoBE5O=+RD6QNxA5ynH-X+-rPN7jA@mail.gmail.com>
	<[email protected]>
	<CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>

Re: Dave Page 2018-06-27 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
> On Tue, Jun 26, 2018 at 8:28 PM, Christoph Berg <[email protected]> wrote:
> 
> > Re: Dave Page 2018-06-26 <CA+OCxow1BDDXK9K1d-pnSAoBE5O=+
> > [email protected]>
> > > ... can be found at https://developer.pgadmin.org/builds/2018-06-26-3.1/
> > > and dpage/pgadmin4:2018-06-26-3.1 on Docker Hub.
> > >
> > > Fahar; please verify for release on Thursday.
> > >
> > > Note that these are the first builds from the new fully automated build
> > > system, and both the Windows and Mac versions now use Python 3, so please
> > > be sure to test with extra care!
> >
> > Hmm, ModuleNotFoundError: No module named 'sshtunnel'
> >
> > Could you perhaps announce new versions that need new python modules a
> > bit earlier, so we have time to package them?
> >
> 
> Good point. Not entirely sure how the mechanics of that would work, given
> that we're trying to shorten release cycles down to a couple of weeks
> (ideally).

Just drop a note "hey we've added $module" once a non-standard
dependency is added.

> That said, for all other builds we're giving up trying to maintain Python
> packages. Instead, we're going to be shipping a pre-built Python venv as
> part of the package, built using Python 3.6. Whilst it's not perfect from a
> "following the packaging rules" perspective, in other cases we're having to
> install modules privately for pgAdmin anyway to avoid conflicts with older,
> vendor supplied versions, so it's really just a different evil rather than
> a new one.

I'm not going to "pip install" or whatever from the build system.

That said, the web/pgadmin/static/*/generated/ directories have
disappeared from the tarball, so pgadmin doesn't load anymore. Could
you please put them back, as I don't think rebuilding them via yarn is
feasible? Because that's not packaged either...

Christoph

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin v3.1 candidate builds and source...
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox