public inbox for [email protected]  

help / color / mirror / Atom feed

From: Shaheed Haque <[email protected]>
To: pgadmin-hackers <[email protected]>
To: Dave Page <[email protected]>
Subject: Re: Making Kerberos optional in the Python wheel
Date: Thu, 04 Mar 2021 10:06:57 +0000
Message-ID: <2770352.mvXUDI8C0e@baba> (raw)
In-Reply-To: <CA+OCxowzCN8wznYjG_631tB2XYgqv5LCXkD49jkXAUtD7d9t3g@mail.gmail.com>
References: <CA+OCxowzCN8wznYjG_631tB2XYgqv5LCXkD49jkXAUtD7d9t3g@mail.gmail.com>

A big thumbs up from me at least :-).

On Thursday, 4 March 2021 10:02:00 GMT Dave Page wrote:
> There have been a couple of complaints that the latest Python wheel
> distribution doesn't install cleanly. This happens when there is no
> pre-built gssapi wheel on PyPi that matches the users combination of Python
> version and platform, *and* the MIT Kerberos development headers etc. are
> not present on the system, so the source wheel cannot be compiled.
> 
> This seems like it's a bit onerous on users, especially if they're on
> Windows where they'll also need a suitable compiler to be installed. The
> attached patch aims to address that by making the Kerberos support optional
> (thankfully, Khushboo made the code handle lack of gssapi libraries).
> 
> To install without gssapi, users would simply do:
> 
> pip install pgadmin4
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl
> 
> To install with gssapi:
> 
> pip install pgadmin4['kerberos']
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos']
> 
> The patch also cleans up some old cruft that was required for now
> unsupported Python versions.
> 
> Thoughts?

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Making Kerberos optional in the Python wheel
  In-Reply-To: <2770352.mvXUDI8C0e@baba>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox