public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Nikolai Zhubr <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Beautify line-ends handling yet more.
Date: Sat, 10 Oct 2015 14:51:03 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CA+OCxoy4Oo2WEXqU5_3nnka759FM1BtqZCKZovE1xKfJavr41w@mail.gmail.com>
	<[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>



> On 10 Oct 2015, at 13:33, Nikolai Zhubr <[email protected]> wrote:
> 
> Hello Dave,
> 09.10.2015 16:31, Dave Page wrote:
> [...]
>> I committed a modified version of this - Mac OS X uses \n as a
>> line-end, so that makes a better default than the old-style \r used on
>> Mac classic.
> 
> Ah, I didn't know that, thanks for explanation.
> 
> I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd propose to also update the corresponding preferences menu. Right now it shows 3 possibilities:
> 
> * Unix (LF)
> * DOS (CRLF)
> * Mac (CR)
> 
> Maybe it would make sense to only provide 2 with the following naming:
> 
> * Unix/Mac (LF)
> * DOS/Windows (CRLF)
> 
> If it is OK then I'll craft a git diff for that (eventually).

I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive amount of code bloating the app or overly complicating the UI.

-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] Beautify line-ends handling yet more.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox