From: Guillaume Lelarge <guillaume@lelarge.info>
To: Dave Page <dpage@pgadmin.org>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgadmin-hackers@postgresql.org
Subject: Re: Patch to support SSL certificate connections
Date: Fri, 28 Jan 2011 19:24:36 +0100
Message-ID: <4D4309E4.8000208@lelarge.info> (raw)
In-Reply-To: <4D42805B.2060002@lelarge.info>
References: <4D3623DB.20105@lelarge.info>
<4D38B269.6000509@lelarge.info>
<AANLkTikQAQPo9acQt39x4WGbmyPO7M-Cs9FF6AxRTMOC@mail.gmail.com>
<4D3A2609.2040406@lelarge.info>
<4D41E9F5.6000808@lelarge.info>
<AANLkTinN-A9Gj48p+b8Ccc6mDc4c5vwefeRV+ANidG_A@mail.gmail.com>
<4D426F77.9050102@lelarge.info>
<AANLkTikaANKktNOjKfUMLYTt6L5ZZUyuWfCSDH7uxTZo@mail.gmail.com>
<4D42805B.2060002@lelarge.info>
Le 28/01/2011 09:37, Guillaume Lelarge a écrit :
> Le 28/01/2011 09:21, Dave Page a écrit :
>> On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 28/01/2011 02:11, Dave Page a écrit :
>>>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
>>>> <guillaume@lelarge.info> wrote:
>>>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>>>>>> according to those.
>>>>>>>>>
>>>>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>>>>>> and changes in the connection code to add those parameters in the
>>>>>>>>> connection string.
>>>>>>>>>
>>>>>>>>
>>>>>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>>>>>
>>>>>>>> Comments?
>>>>>>>
>>>>>>> I would move root cert up before the others. Also CRL.
>>>>>>>
>>>>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>>>>> and cert file are about SSL authentication of the *client* (thus
>>>>>>> *client* certificates). They should definitely be in that order -
>>>>>>> perhaps even grouped with a headline?
>>>>>>>
>>>>>>
>>>>>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>>>>>
>>>>>
>>>>> Here is what I finally managed to do. Comments?
>>>>
>>>> Why the change from the standard layout used everywhere else?
>>>>
>>>
>>> Because Magnus asked for that kind of design? (grouped with a headline)
>>
>> He suggested it, but that doesn't mean it has to be done. If we're
>> going to break the property dialog design guidelines and start laying
>> things out in new formats we need to be *really* careful to avoid
>> getting in an inconsistent mess.
>>
>
> Yeah, I know. And "grouped with a headline" doesn't mean we have to use
> a wxStaticBoxSizer. Anyway, reading your comments and Ashesh's comments,
> I will drop the wxStaticBoxSizer and everyone will be happy:
>
> * no strange issue on MacOSX for Ashesh
> * no weird design for you
> * but still first server certificate and then client certificate for Magnus.
>
> Will try to work on this today.
>
What about this one?
--
Guillaume
http://www.postgresql.frhttp://dalibo.comAttachments:sslfiles_v3.png (image/png, 33.6K) downloadview image
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgadmin-hackers@postgresql.org
Cc: guillaume@lelarge.info, dpage@pgadmin.org, magnus@hagander.net
Subject: Re: Patch to support SSL certificate connections
In-Reply-To: <4D4309E4.8000208@lelarge.info>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox