public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikolai Zhubr <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [Patch] Windows installer: allow manually setting WIXDIR as appropriate.
Date: Sun, 04 Oct 2015 16:31:55 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi all,
04.10.2015 7:55, J.F. Oster wrote:
> Hello,
>
> +1
> I proposed the same once but had no feedback.

I'm actually surprised by the very low feedback on the list altogether.

> Nikolai, why doesn't the first version work for you? I have it done similar:

Because if the variable itself contains quotes (and typically it does, 
to deal with spaces in paths) then AFAICS command interpreter gets 
confused when it sees yet more surrounding quotes in a comparison 
operator in a line like you listed below. I'm no expert in cmd.exe 
behaviour, but at least on windows xp it caused interpreter errors, so I 
just used a simple workaround and it then ran fine.

> if NOT "%WIXDIR%"=="" GOTO WIXDIR_SET
> SET WIXDIR="C:\Program Files (x86)\Windows Installer XML v3\bin"
> :WIXDIR_SET
>
>


Thank you,
Nikolai


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Patch] Windows installer: allow manually setting WIXDIR as appropriate.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox