public inbox for [email protected]  

help / color / mirror / Atom feed

From: Levitt Olivier <[email protected]>
To: [email protected] <[email protected]>
Subject: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
Date: Fri, 13 Dec 2019 14:52:46 +0000
Message-ID: <74F4D0C2ACDFA04BA40C6475ADAE217529FA3FDA@pdexchbalwst03.ad.insee.intra> (raw)

Hi,

When running the docker image in desktop mode (PGADMIN_CONFIG_SERVER_MODE=False), no user is created. That is expected behaviour.
But then the code that imports the servers.json pre-configuration fails as it ties the import to the default user.  

I think line 40 of entrypoint.sh (https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=pkg/docker/entrypoint.sh;h=47d14bf2d41577...) should not specify a user when running in dekstop mode. 
I tested it without --user parameter and it successfully imported the servers.json configuration.

Should I submit a patch ? First time contributing to Pgadmin :)

Regards,
Olivier Levitt

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
  In-Reply-To: <74F4D0C2ACDFA04BA40C6475ADAE217529FA3FDA@pdexchbalwst03.ad.insee.intra>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox