public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Levitt Olivier <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
Date: Tue, 17 Dec 2019 13:15:58 +0530
Message-ID: <CANxoLDcY1QRm=smCy9tfg9MMtYA8txNY0ukRg4VMpyHgRqhHjw@mail.gmail.com> (raw)
In-Reply-To: <74F4D0C2ACDFA04BA40C6475ADAE217529FA40C2@pdexchbalwst03.ad.insee.intra>
References: <74F4D0C2ACDFA04BA40C6475ADAE217529FA3FDA@pdexchbalwst03.ad.insee.intra>
<CAG7mmow_n3Gn0xz7FRFktg20jza8jJSJnMRKg7Xd6=NYBXmhsw@mail.gmail.com>
<74F4D0C2ACDFA04BA40C6475ADAE217529FA40C2@pdexchbalwst03.ad.insee.intra>
Thanks, patch applied.
On Mon, Dec 16, 2019 at 4:42 PM Levitt Olivier <[email protected]>
wrote:
> Hi,
>
> Here is a patch (first contribution \o/) that solves the issue by
> importing the servers.json anonymously when running in DESKTOP mode.
> There may be a better way to check if we are running in DESKTOP mode or
> not but checking PGADMIN_CONFIG_SERVER_MODE should be enough when running
> pgadmin4 in docker.
>
> Regards,
> Olivier Levitt
>
>
> ________________________________________
> From: Ashesh Vashi [[email protected]]
> Sent: 14 December 2019 05:52
> To: Levitt Olivier
> Cc: [email protected]
> Subject: Re: [Pgadmin] [Docker] servers.json import fails when running in
> desktop mode
>
> <http://www.linkedin.com/in/asheshvashi;
>
> On Sat, Dec 14, 2019 at 3:53 AM Levitt Olivier <[email protected]
> <mailto:[email protected]>> wrote:
> Hi,
>
> When running the docker image in desktop mode
> (PGADMIN_CONFIG_SERVER_MODE=False), no user is created. That is expected
> behaviour.
> But then the code that imports the servers.json pre-configuration fails as
> it ties the import to the default user.
>
> I think line 40 of entrypoint.sh (
> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=pkg/docker/entrypoint.sh;h=47d14bf2d41577...)
> should not specify a user when running in dekstop mode.
> I tested it without --user parameter and it successfully imported the
> servers.json configuration.
>
> Should I submit a patch ? First time contributing to Pgadmin :)
> Please do.
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<
> http://www.enterprisedb.com;
>
>
> http://www.linkedin.com/in/asheshvashi
>
> Regards,
> Olivier Levitt
>
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode
In-Reply-To: <CANxoLDcY1QRm=smCy9tfg9MMtYA8txNY0ukRg4VMpyHgRqhHjw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox