public inbox for [email protected]
help / color / mirror / Atom feedFrom: Arun Kollan <[email protected]>
To: Dave Page <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Styling SQL box layout on dialogue
Date: Mon, 11 Apr 2016 11:31:09 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CA+OCxowJPp5WmawaBWwgribUjmDA9autbB4aiRgDG20GathqCg@mail.gmail.com>
<CAMVYmSDTuxc5XSh-=13XsUgTjzDOb7Vc8iw8E+WpxjX5nNZMfQ@mail.gmail.com>
<CA+OCxozGxMmFA96BFBgiMCkEctQSDxi4AXchv3v=CEDuye0cpA@mail.gmail.com>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
Please find attached the zipped version of the patch. I have tested it against the latest version from the repository. I had quick look comparing the patches and it looks to contain the same rules.
Regards,
Arun Kollan
Website: www.enterprisedb.com <http://www.enterprisedb.com/;
EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
> On 11 Apr 2016, at 10:45, Arun Kollan <[email protected]> wrote:
>
> Hi Dave,
> Looks the like the patch is out of sync with the repository. I will create another patch now.
>
> Regards,
> Arun Kollan
> Website: www.enterprisedb.com <http://www.enterprisedb.com/;
> EnterpriseDB Blog: http://blogs.enterprisedb.com/ <http://blogs.enterprisedb.com/;
> Follow us on Twitter: http://www.twitter.com/enterprisedb <http://www.twitter.com/enterprisedb;
>
> This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
>
>
>
>
>> On 11 Apr 2016, at 10:09, Dave Page <[email protected] <mailto:[email protected]>> wrote:
>>
>> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan
>> <[email protected] <mailto:[email protected]>> wrote:
>>> Hi Team,
>>>
>>> please find attached the patch for styling the sql editor on a dialogue
>>> window. The separate rule has been written to include the style specific to
>>> a control window.
>>
>> There still seem to be padding/margin issues on my machine (under
>> Chrome). Am I missing something?
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/;
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com <http://pgsnake.blogspot.com/;
>> Twitter: @pgsnake
>> <Screen Shot 2016-04-11 at 10.07.08.png>
>
Attachments:
[application/octet-stream] sql-box-layout-stylingv2.patch (2.0K, 3-sql-box-layout-stylingv2.patch)
download | inline diff:
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 16f7f0a..16ea37a 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -276,6 +276,11 @@ iframe {
padding-right: 3px;
padding-left: 3px;
}
+.pgadmin-controls.SQL {
+ min-width: 290px;
+ padding-right: 3px;
+ padding-left: 1px;
+}
.pgadmin-controls > textarea.form-control,
.pgadmin-controls > textarea.form-control[disabled] {
min-width: 100%;
@@ -855,11 +860,20 @@ td.edit-cell.editable.sortable.renderable.editor {
}
.sql_field_height_300 {
- height: 300px;
+ height: 340px;
}
.sql_field_height_400 {
- height: 400px;
+ height: 440px;
+}
+
+.tab-pane.SQL {
+ padding: 0px 7px 0px 0px;
+}
+
+.pgadmin-control-group.sql {
+ margin: 0px;
+ padding: 0px;
}
.nav-tabs{
@@ -929,3 +943,7 @@ ul.nav.nav-tabs {
.pgadmin-control-group span.wcTabIcon {
padding-left: 20px;
}
+
+.pgadmin-controls.SQL>.CodeMirror {
+ height: 500px!important;
+}
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 8eaed6d..0f7edc8 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -519,7 +519,7 @@
' id="<%=hId%>" aria-controls="<%=cId%>">',
'<%=label%></a></li>'].join(" ")),
'panel': _.template(
- '<div role="tabpanel" class="tab-pane col-sm-12 col-md-12 col-lg-12 col-xs-12 fade" id="<%=cId%>" aria-labelledby="<%=hId%>"></div>'
+ '<div role="tabpanel" class="tab-pane <%=label%> col-sm-12 col-md-12 col-lg-12 col-xs-12 fade" id="<%=cId%>" aria-labelledby="<%=hId%>"></div>'
)},
render: function() {
this.cleanup();
@@ -1307,7 +1307,7 @@
var SqlTabControl = Backform.SqlTabControl = Backform.Control.extend({
defaults: {
label: "",
- controlsClassName: "pgadmin-controls col-sm-12",
+ controlsClassName: "pgadmin-controls col-sm-12 SQL",
extraClasses: [],
helpMessage: null
},
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Styling SQL box layout on dialogue
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox