public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pravesh Sharma <[email protected]>
To: Rohit Bhati <[email protected]>
Cc: [email protected]
Subject: Re: Require suggestion for issue #6513
Date: Thu, 21 Nov 2024 13:35:03 +0530
Message-ID: <CA+36bxFMDfrBh9OSsXmPMRgtusEsnz8COfrg0d29m86MaJOF8g@mail.gmail.com> (raw)
In-Reply-To: <CABscKVht=_djBvUns0Pio_TDCci76UAYbPsLmYj0Ek3BEbEk+w@mail.gmail.com>
References: <CABscKVht=_djBvUns0Pio_TDCci76UAYbPsLmYj0Ek3BEbEk+w@mail.gmail.com>

Hi Rohit,

In the disconnect database dialog, the button label should be disconnect
not delete.

Thanks,
Pravesh

On Thu, Nov 21, 2024 at 1:18 PM Rohit Bhati <[email protected]>
wrote:

> Hi Hackers,
>
> I have been working on issue #6513
> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
> implemented some changes based on user suggestions. Here’s a summary of the
> modifications I made locally:
>
>    1. *Button Label Changes*:
>       - Updated the labels of the buttons to "Delete" or "Disconnect" for
>       affirmative actions.
>       - Changed the label "No" to "Cancel" for negative actions.
>    2. *Icon Additions*:
>       - Added appropriate icons for the "Disconnect" and "Delete" actions.
>
> I would like your input on whether these changes should be applied
> universally across all delete and disconnect scenarios, or if they should
> be limited to just the database delete and disconnect actions.
>
> Please find the attached screenshots showcasing the changes.
>
>
> Thank you for your feedback!
>
> Best regards,
> Rohit Bhati
>
>
>

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Require suggestion for issue #6513
  In-Reply-To: <CA+36bxFMDfrBh9OSsXmPMRgtusEsnz8COfrg0d29m86MaJOF8g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox