public inbox for [email protected]
help / color / mirror / Atom feedRequire suggestion for issue #6513
7+ messages / 4 participants
[nested] [flat]
* Require suggestion for issue #6513
@ 2024-11-21 07:48 Rohit Bhati <[email protected]>
0 siblings, 4 replies; 7+ messages in thread
From: Rohit Bhati @ 2024-11-21 07:48 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
I have been working on issue #6513
<https://github.com/pgadmin-org/pgadmin4/issues/6513; and have implemented
some changes based on user suggestions. Here’s a summary of the
modifications I made locally:
1. *Button Label Changes*:
- Updated the labels of the buttons to "Delete" or "Disconnect" for
affirmative actions.
- Changed the label "No" to "Cancel" for negative actions.
2. *Icon Additions*:
- Added appropriate icons for the "Disconnect" and "Delete" actions.
I would like your input on whether these changes should be applied
universally across all delete and disconnect scenarios, or if they should
be limited to just the database delete and disconnect actions.
Please find the attached screenshots showcasing the changes.
Thank you for your feedback!
Best regards,
Rohit Bhati
Attachments:
[image/png] Delete database.png (34.8K, ../../CABscKVht=_djBvUns0Pio_TDCci76UAYbPsLmYj0Ek3BEbEk+w@mail.gmail.com/3-Delete%20database.png)
download | view image
[image/png] Disconnect database.png (36.4K, ../../CABscKVht=_djBvUns0Pio_TDCci76UAYbPsLmYj0Ek3BEbEk+w@mail.gmail.com/4-Disconnect%20database.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-21 07:51 Rohit Bhati <[email protected]>
parent: Rohit Bhati <[email protected]>
3 siblings, 0 replies; 7+ messages in thread
From: Rohit Bhati @ 2024-11-21 07:51 UTC (permalink / raw)
To: pgadmin-hackers
updated screenshot for delete database:-
On Thu, Nov 21, 2024 at 1:18 PM Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> I have been working on issue #6513
> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
> implemented some changes based on user suggestions. Here’s a summary of the
> modifications I made locally:
>
> 1. *Button Label Changes*:
> - Updated the labels of the buttons to "Delete" or "Disconnect" for
> affirmative actions.
> - Changed the label "No" to "Cancel" for negative actions.
> 2. *Icon Additions*:
> - Added appropriate icons for the "Disconnect" and "Delete" actions.
>
> I would like your input on whether these changes should be applied
> universally across all delete and disconnect scenarios, or if they should
> be limited to just the database delete and disconnect actions.
>
> Please find the attached screenshots showcasing the changes.
>
>
> Thank you for your feedback!
>
> Best regards,
> Rohit Bhati
>
>
>
Attachments:
[image/png] Screenshot 2024-11-21 at 1.20.41 PM.png (34.8K, ../../CABscKVg98gFSZVhY9J3uwRaiwm-6EA7d8FC4i7ZqNnH7vhPw9g@mail.gmail.com/3-Screenshot%202024-11-21%20at%201.20.41%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-21 08:05 Pravesh Sharma <[email protected]>
parent: Rohit Bhati <[email protected]>
3 siblings, 0 replies; 7+ messages in thread
From: Pravesh Sharma @ 2024-11-21 08:05 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi Rohit,
In the disconnect database dialog, the button label should be disconnect
not delete.
Thanks,
Pravesh
On Thu, Nov 21, 2024 at 1:18 PM Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> I have been working on issue #6513
> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
> implemented some changes based on user suggestions. Here’s a summary of the
> modifications I made locally:
>
> 1. *Button Label Changes*:
> - Updated the labels of the buttons to "Delete" or "Disconnect" for
> affirmative actions.
> - Changed the label "No" to "Cancel" for negative actions.
> 2. *Icon Additions*:
> - Added appropriate icons for the "Disconnect" and "Delete" actions.
>
> I would like your input on whether these changes should be applied
> universally across all delete and disconnect scenarios, or if they should
> be limited to just the database delete and disconnect actions.
>
> Please find the attached screenshots showcasing the changes.
>
>
> Thank you for your feedback!
>
> Best regards,
> Rohit Bhati
>
>
>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-21 08:05 Rohit Bhati <[email protected]>
parent: Rohit Bhati <[email protected]>
3 siblings, 0 replies; 7+ messages in thread
From: Rohit Bhati @ 2024-11-21 08:05 UTC (permalink / raw)
To: pgadmin-hackers
Sorry for the inconvenience, Due to a selection mistake, I have sent wrong
screenshots in my previous mail.
Please check the updated screenshot attached for disconnect and delete
database:-
On Thu, Nov 21, 2024 at 1:18 PM Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> I have been working on issue #6513
> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
> implemented some changes based on user suggestions. Here’s a summary of the
> modifications I made locally:
>
> 1. *Button Label Changes*:
> - Updated the labels of the buttons to "Delete" or "Disconnect" for
> affirmative actions.
> - Changed the label "No" to "Cancel" for negative actions.
> 2. *Icon Additions*:
> - Added appropriate icons for the "Disconnect" and "Delete" actions.
>
> I would like your input on whether these changes should be applied
> universally across all delete and disconnect scenarios, or if they should
> be limited to just the database delete and disconnect actions.
>
> Please find the attached screenshots showcasing the changes.
>
>
> Thank you for your feedback!
>
> Best regards,
> Rohit Bhati
>
>
>
Attachments:
[image/png] Screenshot 2024-11-21 at 1.31.12 PM.png (39.4K, ../../CABscKVghYruQb_dFZOiJTYyhDiK33kfXG807-styAfjdxbVHpw@mail.gmail.com/3-Screenshot%202024-11-21%20at%201.31.12%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2024-11-21 at 1.20.41 PM.png (34.8K, ../../CABscKVghYruQb_dFZOiJTYyhDiK33kfXG807-styAfjdxbVHpw@mail.gmail.com/4-Screenshot%202024-11-21%20at%201.20.41%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-21 18:10 Usman Khan <[email protected]>
parent: Rohit Bhati <[email protected]>
3 siblings, 1 reply; 7+ messages in thread
From: Usman Khan @ 2024-11-21 18:10 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Yes, I think it would be nice to do it across all appropriate places.
'Disconnect' is available for Server and Database, while Delete is
available across all database objects in the tree area.
On Thu, Nov 21, 2024 at 12:48 PM Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> I have been working on issue #6513
> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
> implemented some changes based on user suggestions. Here’s a summary of the
> modifications I made locally:
>
> 1. *Button Label Changes*:
> - Updated the labels of the buttons to "Delete" or "Disconnect" for
> affirmative actions.
> - Changed the label "No" to "Cancel" for negative actions.
> 2. *Icon Additions*:
> - Added appropriate icons for the "Disconnect" and "Delete" actions.
>
> I would like your input on whether these changes should be applied
> universally across all delete and disconnect scenarios, or if they should
> be limited to just the database delete and disconnect actions.
>
> Please find the attached screenshots showcasing the changes.
>
>
> Thank you for your feedback!
>
> Best regards,
> Rohit Bhati
>
>
>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-27 07:11 Rohit Bhati <[email protected]>
parent: Usman Khan <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Rohit Bhati @ 2024-11-27 07:11 UTC (permalink / raw)
To: pgadmin-hackers
Hi Dave,
I hope you're doing well. I would greatly appreciate it if you could
provide your suggestions also on this issue.
Thank you in advance.
Best regards,
Rohit Bhati
On Thu, Nov 21, 2024 at 11:40 PM Usman Khan <[email protected]> wrote:
> Yes, I think it would be nice to do it across all appropriate places.
> 'Disconnect' is available for Server and Database, while Delete is
> available across all database objects in the tree area.
>
>
>
>
>
> On Thu, Nov 21, 2024 at 12:48 PM Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Hackers,
>>
>> I have been working on issue #6513
>> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
>> implemented some changes based on user suggestions. Here’s a summary of the
>> modifications I made locally:
>>
>> 1. *Button Label Changes*:
>> - Updated the labels of the buttons to "Delete" or "Disconnect"
>> for affirmative actions.
>> - Changed the label "No" to "Cancel" for negative actions.
>> 2. *Icon Additions*:
>> - Added appropriate icons for the "Disconnect" and "Delete"
>> actions.
>>
>> I would like your input on whether these changes should be applied
>> universally across all delete and disconnect scenarios, or if they should
>> be limited to just the database delete and disconnect actions.
>>
>> Please find the attached screenshots showcasing the changes.
>>
>>
>> Thank you for your feedback!
>>
>> Best regards,
>> Rohit Bhati
>>
>>
>>
>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Require suggestion for issue #6513
@ 2024-11-27 16:59 Dave Page <[email protected]>
parent: Rohit Bhati <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Dave Page @ 2024-11-27 16:59 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi Rohit!
On Wed, 27 Nov 2024 at 07:12, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I hope you're doing well. I would greatly appreciate it if you could
> provide your suggestions also on this issue.
>
I'm fine with the button label changes. We should make sure the text is
structured consistently though:
Are you sure you want to disconnect from the database "FooBar"?
Are you sure you want to delete the database "FooBar"?
For the delete option, I would also:
- Make Cancel the default option.
- Colour the button ("danger" in the palette)
Thanks!
> Thank you in advance.
>
> Best regards,
> Rohit Bhati
>
>
> On Thu, Nov 21, 2024 at 11:40 PM Usman Khan <[email protected]> wrote:
>
>> Yes, I think it would be nice to do it across all appropriate places.
>> 'Disconnect' is available for Server and Database, while Delete is
>> available across all database objects in the tree area.
>>
>>
>>
>>
>>
>> On Thu, Nov 21, 2024 at 12:48 PM Rohit Bhati <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> I have been working on issue #6513
>>> <https://github.com/pgadmin-org/pgadmin4/issues/6513; and have
>>> implemented some changes based on user suggestions. Here’s a summary of the
>>> modifications I made locally:
>>>
>>> 1. *Button Label Changes*:
>>> - Updated the labels of the buttons to "Delete" or "Disconnect"
>>> for affirmative actions.
>>> - Changed the label "No" to "Cancel" for negative actions.
>>> 2. *Icon Additions*:
>>> - Added appropriate icons for the "Disconnect" and "Delete"
>>> actions.
>>>
>>> I would like your input on whether these changes should be applied
>>> universally across all delete and disconnect scenarios, or if they should
>>> be limited to just the database delete and disconnect actions.
>>>
>>> Please find the attached screenshots showcasing the changes.
>>>
>>>
>>> Thank you for your feedback!
>>>
>>> Best regards,
>>> Rohit Bhati
>>>
>>>
>>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-11-27 16:59 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-11-21 07:48 Require suggestion for issue #6513 Rohit Bhati <[email protected]>
2024-11-21 07:51 ` Rohit Bhati <[email protected]>
2024-11-21 08:05 ` Pravesh Sharma <[email protected]>
2024-11-21 08:05 ` Rohit Bhati <[email protected]>
2024-11-21 18:10 ` Usman Khan <[email protected]>
2024-11-27 07:11 ` Rohit Bhati <[email protected]>
2024-11-27 16:59 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox