Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
Date: Thu, 3 Jan 2019 15:09:27 +0000
Message-ID: <CA+OCxow9Kw-KAL366JBPxZ1p4cRDuMe=DWv7v5AygAcm8v19hQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_niKinU7MWXxth4Em9BQc=xDKOwgbApL58viZq2zJ=phw@mail.gmail.com>
References: <[email protected]>
	<CA+OCxoyp8XjOa0xdiqoohiQ1Bm0fcrruXTWu-Y_mqY5LaGeBoQ@mail.gmail.com>
	<CAM9w-_ngsgJxJOJKngc-3W8tqNymKeZjBCuW2_VN-nb4k5du=g@mail.gmail.com>
	<CA+OCxoxHWJK+XA6zROKWznJkJf1=adDEoafqCoz9BPnMvmtzAg@mail.gmail.com>
	<CA+OCxoyuDXfZR2zNKONy-CWWYbo_xAeLZRVZwVZ=1_gU+4zUAg@mail.gmail.com>
	<CAM9w-_mXaptQzE45a3eRfLB5qG0R+qUm6JnAnR4C6rOZ8fiJFw@mail.gmail.com>
	<CA+OCxowym3tJZfDkOJkqfsNbaxT=Z=nnxCEQWF4nm+HL5q8_qQ@mail.gmail.com>
	<CAM9w-_nXoXLjm4jyJKsZ1vOXJLei7akyrBQMOY+p_jmDzmEmdg@mail.gmail.com>
	<CA+OCxow69BHrCT7JcdfVyFwn0JnWEszaMdwxuWaxBddKf=h4mg@mail.gmail.com>
	<CAM9w-_myZ=B-Nzt9DGAnvXVQgz3szAbe13cLPC4kSSXbUQXt6w@mail.gmail.com>
	<CAM9w-_=sK8X=VXE8mqVY6+McuM=EXwg8_xJ56tf_0pHDvvH7uQ@mail.gmail.com>
	<CAM9w-_nkvOB5VTGwLkhDiNUYGF1yho0H6BniUoKFM8vveb3zKg@mail.gmail.com>
	<CANxoLDeLe0YKm4hZOpwFX79p+DuR0ocibYkH8WFLtk6XwLNK2w@mail.gmail.com>
	<CAM9w-_niKinU7MWXxth4Em9BQc=xDKOwgbApL58viZq2zJ=phw@mail.gmail.com>

Hi

On Thu, Jan 3, 2019 at 10:20 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Further improvement patch. With this patch, following are fixed:
> - Fieldset control design changes
> - File dialog - files list header should not scroll with the body and
> stick to the top
> - Debugger input args dialog cancel button should always be enabled
> - Backup globals dialog controls aligmnent correction
> - In View Data query tool, explain related buttons should be disabled
> - Autocomplete design changes
>
> I have also fixed one issue which was created by the copyright changes in
> the file - pgadmin/misc/file_manager/templates/file_manager/js/languages/en.js.
> The en.js file contains json data and adding copyright comments to it
> caused JSON parsing failure in file dialog. As an improvement, I have
> renamed the file from en.js to en.json at all the places to avoid such
> changes in future.
>
> Kindly review.
>

Thanks - applied.

A few other things that I noticed (or have been bugging me):

- The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and
setting the font-weight to normal on the menu options (but not the product
name) seems much better to me (and adjusting everything else as required of
course).

- In the file dialogue, the column headers don't line up with the columns
in the rows.

- In list mode of the file dialogue, can we use the same coloured icons as
we do in icon mode? Obviously smaller...

- "Show hidden files and folders ?" shouldn't have a space before the
question mark.

- The menu bar on the file dialogue doesn't match the styling of the menu
bar on the query tool (in fact, even the left and right ends of it are
styled differently from each other).

- The line numbers in the gutter of CodeMirror are tiny.

- I'm not convinced about the boldness of the tab titles - I think the are
just a little too harsh - can you change the font-weight to normal for them
please (both the wcDocker and Bootstrap tabs)?

Also (for another day); we should move the file dialog messages out of the
JSON file altogether and use our normal translation mechanisms.

Thanks again :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (29+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica
  In-Reply-To: <CA+OCxow9Kw-KAL366JBPxZ1p4cRDuMe=DWv7v5AygAcm8v19hQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox