public inbox for [email protected]  

help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Dialogue control buttons should be consistent (pgAdmin4)
Date: Sun, 8 Jan 2017 10:35:49 +0000
Message-ID: <CA+OCxow9p_12KSQXX8nPpPC=QjLkYfx0+y47=CRKqc0Zq+482Q@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZTSSsps_Zb033pSHg+v_3rvtUunoAZtCWVDnze+uiUv0w@mail.gmail.com>
References: <CAKKotZTSSsps_Zb033pSHg+v_3rvtUunoAZtCWVDnze+uiUv0w@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks, patch applied.

On Friday, January 6, 2017, Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA patch to fix the issue where  some dialogue control buttons were not
> consistent with others dialogs.
> RM#1364
>
> Patch fixes,
> 1) Preferences: Close, Maximise, Pin
> - Removed Pin button
>
> 2) Wizards: Close
> - Added Maximise button, which is can used with 'show_header_maximize_btn'
> option.
>
> 3) Properties: Close
> - N/A, As this is custom wcDocker panel not alertify dialog.
>
> 4) User manager: Maximise
> - We can't have close button in User Manager as data validation was main
> requirement, If user clicks on right top close button while having dirty
> data in dialog then we can't stop alertify dialog from closing even with
> confirm prompt hence we have removed the button.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (2+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: Dialogue control buttons should be consistent (pgAdmin4)
  In-Reply-To: <CA+OCxow9p_12KSQXX8nPpPC=QjLkYfx0+y47=CRKqc0Zq+482Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox