public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11
Date: Fri, 8 Jun 2018 09:51:34 +0100
Message-ID: <CA+OCxowGMOcrHAv4Q4PSu58PjQV3DfYtRuvba6wg-G_27uMjhA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdQLJHccik87AkTPY5nop0P3mF1xy2wEBNkoSSssmumMQ@mail.gmail.com>
References: <CAFOhELdzaBaPE1ev9t61+e3fbTDYNsMod1wMLRmG3YAWP5jpug@mail.gmail.com>
	<CAFOhELdQLJHccik87AkTPY5nop0P3mF1xy2wEBNkoSSssmumMQ@mail.gmail.com>

Hi

On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please ignore my previous patch, find the attached updated one.
>

I found a couple of issues with this:

- Clicking the + button on the Parameters tab does nothing in either Create
or Edit modes

- The debugger fails to start (though, perhaps that's because the plugin
doesn't have Ashesh's latest patches in it).

FYI, I was trying to test the debugger with:

-- PROCEDURE: public.dummy_proc(integer)

-- DROP PROCEDURE public.dummy_proc(integer);

CREATE OR REPLACE  PROCEDURE public.dummy_proc(
id integer)
LANGUAGE 'plpgsql'

AS $BODY$BEGIN
  raise notice 'id is %', id;
END;$BODY$;

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11
  In-Reply-To: <CA+OCxowGMOcrHAv4Q4PSu58PjQV3DfYtRuvba6wg-G_27uMjhA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox